From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D988CC433F5 for ; Mon, 4 Apr 2022 07:44:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377784AbiDDHqe (ORCPT ); Mon, 4 Apr 2022 03:46:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357956AbiDDHq2 (ORCPT ); Mon, 4 Apr 2022 03:46:28 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08712237D4; Mon, 4 Apr 2022 00:44:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wK+J0MSOSpXOs7DxaA01v/+8Kp5RPaW5E6MQ/XdwYEQ=; b=APwuwZPJFpb5tUSZJOyrXP90mz JV+p35fusRoaGWCyKiRU1GBIg5FjoT/xD0aQvTDAn7e9LqrCD4+UF3KHpNp76BKaFwSVvy+eNY5wq s7BpVw6caTHoT9a3EwgVsDIbVY3qruf1QjUslxwHNj9SBaKhkjWPFeveVQtFwM34xZfZ5PTgVKlWw Mt8aBsfU9p++B92/TkqqKsJdF+F/wHG55QOIAoKGaB07YfyabgTQD7YZKbpzbSUBCvZ7HshCR+YLv JVBBZdhUGSsCk5luUmF0hjZK8hBJDOngeI8nMJy7NNfCzdOLdFxzVTezJJTKqvUbayS6jE7/Xx8P9 3zX8FkHg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbHO3-00DfPU-01; Mon, 04 Apr 2022 07:44:31 +0000 Date: Mon, 4 Apr 2022 00:44:30 -0700 From: Christoph Hellwig To: Masahiro Yamada Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 8/8] virtio_ring.h: do not include from exported header Message-ID: References: <20220404061948.2111820-1-masahiroy@kernel.org> <20220404061948.2111820-9-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220404061948.2111820-9-masahiroy@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 04, 2022 at 03:19:48PM +0900, Masahiro Yamada wrote: > vr->num = num; > vr->desc = p; > vr->avail = (struct vring_avail *)((char *)p + num * sizeof(struct vring_desc)); > - vr->used = (void *)(((uintptr_t)&vr->avail->ring[num] + sizeof(__virtio16) > + vr->used = (void *)(((__kernel_uintptr_t)&vr->avail->ring[num] + sizeof(__virtio16) > + align-1) & ~(align - 1)); This really does not look like it should be in a uapi header to start with.