linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ionela Voinescu <ionela.voinescu@arm.com>
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com,
	Pierre.Gondois@arm.com, viresh.kumar@linaro.org,
	rafael@kernel.org, daniel.lezcano@linaro.org,
	linux-pm@vger.kernel.org, mka@chromium.org, nm@ti.com,
	sboyd@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, cristian.marussi@arm.com,
	sudeep.holla@arm.com, matthias.bgg@gmail.com
Subject: Re: [RESEND][PATCH 8/8] powercap: DTPM: Check for Energy Model type
Date: Mon, 4 Apr 2022 17:03:05 +0100	[thread overview]
Message-ID: <YksWubveJv2ei2pp@arm.com> (raw)
In-Reply-To: <20220321095729.20655-9-lukasz.luba@arm.com>

On Monday 21 Mar 2022 at 09:57:29 (+0000), Lukasz Luba wrote:
> The Energy Model power values might be artificial. In such case
> it's safe to bail out during the registration, since the PowerCap
> framework supports only micro-Watts.
> 
> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
> ---
>  drivers/powercap/dtpm_cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/powercap/dtpm_cpu.c b/drivers/powercap/dtpm_cpu.c
> index bca2f912d349..f5eced0842b3 100644
> --- a/drivers/powercap/dtpm_cpu.c
> +++ b/drivers/powercap/dtpm_cpu.c
> @@ -211,7 +211,7 @@ static int __dtpm_cpu_setup(int cpu, struct dtpm *parent)
>  		return 0;
>  
>  	pd = em_cpu_get(cpu);
> -	if (!pd)
> +	if (!pd || em_is_artificial(pd))
>  		return -EINVAL;
>  
>  	dtpm_cpu = kzalloc(sizeof(*dtpm_cpu), GFP_KERNEL);

Reviewed-by: Ionela Voinescu <ionela.voinescu@arm.com>

> -- 
> 2.17.1
> 

  reply	other threads:[~2022-04-04 21:49 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-21  9:57 [RESEND][PATCH 0/8] Introduce support for artificial Energy Model Lukasz Luba
2022-03-21  9:57 ` [RESEND][PATCH 1/8] PM: EM: Add .get_cost() callback Lukasz Luba
2022-04-04 16:00   ` Ionela Voinescu
2022-03-21  9:57 ` [RESEND][PATCH 2/8] PM: EM: Add artificial EM flag Lukasz Luba
2022-04-04 16:01   ` Ionela Voinescu
2022-03-21  9:57 ` [RESEND][PATCH 3/8] PM: EM: Use the new .get_cost() callback while registering EM Lukasz Luba
2022-04-04 16:01   ` Ionela Voinescu
2022-03-21  9:57 ` [RESEND][PATCH 4/8] PM: EM: Change the order of arguments in the .active_power() callback Lukasz Luba
2022-04-04 16:02   ` Ionela Voinescu
2022-03-21  9:57 ` [RESEND][PATCH 5/8] PM: EM: Remove old debugfs files and print all 'flags' Lukasz Luba
2022-04-04 16:02   ` Ionela Voinescu
2022-04-04 16:31     ` Lukasz Luba
2022-03-21  9:57 ` [RESEND][PATCH 6/8] Documentation: EM: Add artificial EM registration description Lukasz Luba
2022-04-04 16:02   ` Ionela Voinescu
2022-03-21  9:57 ` [RESEND][PATCH 7/8] thermal: cooling: Check Energy Model type in cpufreq_cooling and devfreq_cooling Lukasz Luba
2022-03-28  3:27   ` Viresh Kumar
2022-03-29  6:37     ` Lukasz Luba
2022-04-04 16:02   ` Ionela Voinescu
2022-03-21  9:57 ` [RESEND][PATCH 8/8] powercap: DTPM: Check for Energy Model type Lukasz Luba
2022-04-04 16:03   ` Ionela Voinescu [this message]
2022-04-04 12:35 ` [RESEND][PATCH 0/8] Introduce support for artificial Energy Model Lukasz Luba
2022-04-12  6:53   ` Lukasz Luba
2022-04-13 14:29     ` Rafael J. Wysocki
2022-04-13 14:47       ` Lukasz Luba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YksWubveJv2ei2pp@arm.com \
    --to=ionela.voinescu@arm.com \
    --cc=Pierre.Gondois@arm.com \
    --cc=cristian.marussi@arm.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mka@chromium.org \
    --cc=nm@ti.com \
    --cc=rafael@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).