From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8C99C433F5 for ; Tue, 5 Apr 2022 05:36:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229889AbiDEFiB (ORCPT ); Tue, 5 Apr 2022 01:38:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229708AbiDEFhz (ORCPT ); Tue, 5 Apr 2022 01:37:55 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 908166C90A; Mon, 4 Apr 2022 22:35:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3b3CGMEtvbbiWr5yzpB1vkgXknPZ0unzkS2usWuM5zQ=; b=oprcixATceNR1lvr6wPiAeAep8 9zCOtNH/nU1hogoIN80xVbrqnlQoEfQVvq7Bn35n7AX6HZ7xYdG3NZeHRdaP+dlWiBobrhoTmG9Qg HsTTBXyOtCN2ceRV76QybHMHpF/a0FPihgyb0BpCzLcXL3osENOfMq2vB/7W4q0QwCUN5G2lSJopz c/mT2S458mCRhSxI54khZkQ7lr20mNUpjOp+6nX1gO4DR933XIb3HXhI4JZYIxUwfpSH2Ys01vnwG hHHs2tI7mkc07epLdb2K6Rh+C8nB2oLfQuoaln8JY4m66vJ4pfBIsuqyT+Qg29P4THEvEnbFOYiuk MaFb58XQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbbr6-00HAqV-45; Tue, 05 Apr 2022 05:35:52 +0000 Date: Mon, 4 Apr 2022 22:35:52 -0700 From: Christoph Hellwig To: Arnd Bergmann Cc: Christoph Hellwig , Masahiro Yamada , Linux Kernel Mailing List , Linux Kbuild mailing list , linux-arch Subject: Re: [PATCH 8/8] virtio_ring.h: do not include from exported header Message-ID: References: <20220404061948.2111820-1-masahiroy@kernel.org> <20220404061948.2111820-9-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 04, 2022 at 10:04:02AM +0200, Arnd Bergmann wrote: > The header is shared between kernel and other projects using virtio, such as > qemu and any boot loaders booting from virtio devices. It's not technically a > /kernel/ ABI, but it is an ABI and for practical reasons the kernel version is > maintained as the master copy if I understand it correctly. Besides that fact that as you correctly states these are not a UAPI at all, qemu and bootloades are not specific to Linux and can't require a specific kernel version. So the same thing we do for file system formats or network protocols applies here: just copy the damn header. And as stated above any reasonably portable userspace needs to have a copy anyway. If it is just as a "master copy" it can live in drivers/virtio/, just like we do for other formats.