From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89CD1C433F5 for ; Tue, 5 Apr 2022 07:01:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231338AbiDEHDm (ORCPT ); Tue, 5 Apr 2022 03:03:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231331AbiDEHDj (ORCPT ); Tue, 5 Apr 2022 03:03:39 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D327A11A0A; Tue, 5 Apr 2022 00:01:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mp3FkWfau1S2xgosNtCUIbLswXRyF5ZJmpSQNxIjOFE=; b=PceITjenUqvRPWFAG6YacvJf+N BsmuQX2njcZATW05zeEES/1ee8MArXUr7R6qqJwCDSTFPAT1Zk78SOOan1d9vu4cJOirnaXtA+WJX MKxURMhhS0wEyDQ0AuT0m8T3UsDgEX3so22MnTCf++9VWRjdNbT7Y318dAxRmpfkexBNYZLbLV1ms AyrG3GcQkTK/zHEf8faCUzZ5sattia6epZcg0hxU+HVLWBA6P4AOiyEX2dRta+u90l818EBP5JzhQ eAiPAGzhMrpvLYooUfhjaAXxSalShLj7i9+sF6Pe7nVtJbO9eCtJ/U1V8FWl4XSIbIYWJN1iPJYBL drGYOZfg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbdC3-00HOXX-UA; Tue, 05 Apr 2022 07:01:35 +0000 Date: Tue, 5 Apr 2022 00:01:35 -0700 From: Christoph Hellwig To: Arnd Bergmann Cc: Christoph Hellwig , Masahiro Yamada , Linux Kernel Mailing List , Linux Kbuild mailing list , linux-arch , "Michael S. Tsirkin" , Jason Wang , virtualization list Subject: Re: [PATCH 8/8] virtio_ring.h: do not include from exported header Message-ID: References: <20220404061948.2111820-1-masahiroy@kernel.org> <20220404061948.2111820-9-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 05, 2022 at 08:29:36AM +0200, Arnd Bergmann wrote: > I think the users all have their own copies, at least the ones I could > find on codesearch.debian.org. However, there are 27 virtio_*.h > files in include/uapi/linux that probably should stay together for > the purpose of defining the virtio protocol, and some others might > be uapi relevant. > > I see that at least include/uapi/linux/vhost.h has ioctl() definitions > in it, and includes the virtio_ring.h header indirectly. Uhh. We had a somilar mess (but at a smaller scale) in nvme, where the uapi nvme.h contained both the UAPI and the protocol definition. We took a hard break to only have a nvme_ioctl.h in the uapi header and linux/nvme.h for the protocol. This did break a bit of userspace compilation (but not running obviously) at the time, but really made the headers much easier to main. Some userspace keeps on copying nvme.h with the protocol definitions.