From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Carlos Bilbao <carlos.bilbao@amd.com>
Cc: bp@alien8.de, tglx@linutronix.de, mingo@redhat.com,
dave.hansen@linux.intel.com, x86@kernel.org,
linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
bilbao@vt.edu
Subject: Re: [PATCH v2 2/2] x86/mce: Add messages to describe panic machine errors on AMD's MCEs grading
Date: Tue, 5 Apr 2022 17:38:59 +0000 [thread overview]
Message-ID: <Ykx+swi/SBjaEzLq@yaz-ubuntu> (raw)
In-Reply-To: <20220331163849.6850-3-carlos.bilbao@amd.com>
On Thu, Mar 31, 2022 at 11:38:50AM -0500, Carlos Bilbao wrote:
...
> static noinstr int mce_severity_amd(struct mce *m, struct pt_regs *regs, char **msg, bool is_excp)
> {
> int ret;
> + char *panic_msg;
Order variable lines from longest to shortest.
And the pointer should be initiliazed to NULL like Mike said also.
>
> /*
> * Default return value: Action required, the error must be handled
> @@ -316,6 +317,7 @@ static noinstr int mce_severity_amd(struct mce *m, struct pt_regs *regs, char **
>
> /* Processor Context Corrupt, no need to fumble too much, die! */
> if (m->status & MCI_STATUS_PCC) {
> + panic_msg = "Processor Context Corrupt";
> ret = MCE_PANIC_SEVERITY;
> goto amd_severity;
> }
> @@ -339,16 +341,21 @@ static noinstr int mce_severity_amd(struct mce *m, struct pt_regs *regs, char **
>
> if (((m->status & MCI_STATUS_OVER) && !mce_flags.overflow_recov)
> || !mce_flags.succor) {
> + panic_msg = "Uncorrected unrecoverable error";
So these two cases should definitely be separate. One is "Overflowed
uncorrected error without MCA Overflow Recovery", and the other is
"Uncorrected error without MCA Recovery".
> ret = MCE_PANIC_SEVERITY;
> goto amd_severity;
> }
>
> if (error_context(m, regs) == IN_KERNEL) {
> + panic_msg = "Uncorrected error in kernel context";
This should be "Uncorrected unrecoverable error in kernel context". There is
the IN_KERNEL_RECOV error context for a recoverable error in kernel context.
Thanks,
Yazen
next prev parent reply other threads:[~2022-04-05 20:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 16:38 [PATCH v2 0/2] x86/mce: Grade new machine errors for AMD MCEs and include messages for panic cases Carlos Bilbao
2022-03-31 16:38 ` [PATCH v2 1/2] x86/mce: Extend AMD severity grading function with new types of errors Carlos Bilbao
2022-04-05 17:18 ` Yazen Ghannam
2022-04-05 17:24 ` Carlos Bilbao
2022-04-05 17:41 ` Yazen Ghannam
2022-04-05 17:46 ` Carlos Bilbao
2022-03-31 16:38 ` [PATCH v2 2/2] x86/mce: Add messages to describe panic machine errors on AMD's MCEs grading Carlos Bilbao
2022-03-31 17:17 ` Day, Michael
2022-04-05 17:38 ` Yazen Ghannam [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-03-31 16:32 [PATCH v2 0/2] x86/mce: Grade new machine errors for AMD MCEs and include messages for panic cases Carlos Bilbao
2022-03-31 16:32 ` [PATCH v2 2/2] x86/mce: Add messages to describe panic machine errors on AMD's MCEs grading Carlos Bilbao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ykx+swi/SBjaEzLq@yaz-ubuntu \
--to=yazen.ghannam@amd.com \
--cc=bilbao@vt.edu \
--cc=bp@alien8.de \
--cc=carlos.bilbao@amd.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).