From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB25AC433FE for ; Wed, 20 Apr 2022 11:49:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378075AbiDTLwJ (ORCPT ); Wed, 20 Apr 2022 07:52:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234463AbiDTLwI (ORCPT ); Wed, 20 Apr 2022 07:52:08 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8206041FBB; Wed, 20 Apr 2022 04:49:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id ECD26CE1D7A; Wed, 20 Apr 2022 11:49:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F999C385A1; Wed, 20 Apr 2022 11:49:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650455359; bh=9NypnRFtmDHEIVYZtB9K0mzLsLVLYiYoDBvugKIf1ho=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A2TEfjgVIL8TMywOaYsWvLmUDrMT2MoA+x3KcjIFu7ALui/D5hf/6IH1FKGknNg5h VsIRgxu3Wp7JXv/7YhTjWRF+Sk30OhFHBoygGEZHOAUoeA5FGiizpCCzw5k3cPiHyd FNUEpSDiqlOXhzRMpp3nB4fwm+pOtvg2b59j3KnJbawY3Lhbls+21VD874lj6g7C4Z NhE52wsZVGfmU1NLyW7rcfsFh/slHtqlf16duEAq9vO+PdqGP8/756pdMPrOzpmSkl T6yz9z9U1xVC6mFz/Gxrim8n/CKkkxcV6lFB3r3Ec82ZMx06UPUrUXw5jdeaDZL+9k LVuu65rVkypIg== Date: Wed, 20 Apr 2022 17:19:15 +0530 From: Vinod Koul To: Haowen Bai Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3] dmaengine: pl08x: drop the useless function Message-ID: References: <1649726180-13133-1-git-send-email-baihaowen@meizu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1649726180-13133-1-git-send-email-baihaowen@meizu.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12-04-22, 09:16, Haowen Bai wrote: > Unneeded variable: "retval". Return "NULL" , so we have to make code clear. > better way, drop the function. Applied, thanks -- ~Vinod