From: Vinod Koul <vkoul@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: qcom: sm8350: Add GENI I2C/SPI DMA channels
Date: Mon, 18 Apr 2022 12:49:24 +0530 [thread overview]
Message-ID: <Yl0Q/Hbkyp5/sH8T@matsya> (raw)
In-Reply-To: <YlZKIKR1iHO+Btwk@ripper>
On 12-04-22, 20:57, Bjorn Andersson wrote:
> On Tue 12 Apr 20:14 PDT 2022, Vinod Koul wrote:
>
> > On 12-04-22, 14:51, Bjorn Andersson wrote:
> > > The GENI I2C and SPI controllers may use the GPI DMA engine, define the
> > > rx and tx channels for these controllers to enable this.
> > >
> > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > > ---
> > > arch/arm64/boot/dts/qcom/sm8350.dtsi | 108 +++++++++++++++++++++++++++
> > > 1 file changed, 108 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> > > index 7e585d9e4c68..8547c0b2f060 100644
> > > --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> > > @@ -721,6 +721,9 @@ i2c14: i2c@880000 {
> > > pinctrl-names = "default";
> > > pinctrl-0 = <&qup_i2c14_default>;
> > > interrupts = <GIC_SPI 373 IRQ_TYPE_LEVEL_HIGH>;
> > > + dmas = <&gpi_dma2 0 0 QCOM_GPI_I2C>,
> > > + <&gpi_dma2 1 0 QCOM_GPI_I2C>;
> > > + dma-names = "tx", "rx";
> >
> > I have been thinking about this. I dont feel this is right approach here
> > as this is board dependent and having the firmware loaded on the board..
> >
> > This was tested on HDK and can fail in MTP or other boards.. which might
> > be in FIFO mode
> >
>
> But if the controller is in FIFO mode, then !fifo_disable so we wouldn't
> try to pick up the dmas. And in the opposite case, i.e. when
> fifo_disable, the introduction of the GPI implementation meant that the
> i2c driver wouldn't no longer probe without the dmas specified.
>
> Unfortunately we don't have any i2c busses enabled on the MTP currently,
> so I'm not able to validate this easily.
>
>
> For the SPI driver though, the same logic is used to invoke
> spi_geni_grab_gpi_chan(). So dmas will only be considered if
> fifo_disabled is set.
Right, I tested that and it works just fine. So lets go ahead with this
approach
> That said, in the even that the SPI driver finds a fifo_disabled
> controller and dma_request_chan() returns an error, we will fall back to
> fifo mode instead. I'm not sure if that's desirable...
I agree, we should not fall back, that does not make sense at all
--
~Vinod
next prev parent reply other threads:[~2022-04-18 7:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 21:51 [PATCH 1/3] arm64: dts: qcom: sm8350: Define GPI DMA engines Bjorn Andersson
2022-04-12 21:51 ` [PATCH 2/3] arm64: dts: qcom: sm8350: Add GENI I2C/SPI DMA channels Bjorn Andersson
2022-04-13 3:14 ` Vinod Koul
2022-04-13 3:57 ` Bjorn Andersson
2022-04-18 7:19 ` Vinod Koul [this message]
2022-04-18 8:01 ` Vinod Koul
2022-04-12 21:51 ` [PATCH 3/3] arm64: dts: qcom: sm8350-hdk: Enable &gpi_dma1 Bjorn Andersson
2022-04-18 8:02 ` Vinod Koul
2022-04-18 7:18 ` [PATCH 1/3] arm64: dts: qcom: sm8350: Define GPI DMA engines Vinod Koul
2022-04-21 14:26 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yl0Q/Hbkyp5/sH8T@matsya \
--to=vkoul@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).