From: Petr Mladek <pmladek@suse.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: register_console: was: Re: [PATCH printk v2 11/12] printk: extend console_lock for proper kthread support
Date: Fri, 8 Apr 2022 15:52:37 +0200 [thread overview]
Message-ID: <YlA+JYC1ohU3LKuR@alley> (raw)
In-Reply-To: <20220405132535.649171-12-john.ogness@linutronix.de>
On Tue 2022-04-05 15:31:34, John Ogness wrote:
> Currently threaded console printers synchronize against each
> other using console_lock(). However, different console drivers
> are unrelated and do not require any synchronization between
> each other. Removing the synchronization between the threaded
> console printers will allow each console to print at its own
> speed.
>
> But the threaded consoles printers do still need to synchronize
> against console_lock() callers. Introduce a per-console mutex
> and a new console flag CON_THD_BLOCKED to provide this
> synchronization.
>
> console_lock() is modified so that it must acquire the mutex
> of each console in order to set the CON_THD_BLOCKED flag.
> Console printing threads will acquire their mutex while
> printing a record. If CON_THD_BLOCKED was set, the thread will
> go back to sleep instead of printing.
>
> The reason for the CON_THD_BLOCKED flag is so that
> console_lock() callers do not need to acquire multiple console
> mutexes simultaneously, which would introduce unnecessary
> complexity due to nested mutex locking.
>
> However, threaded console printers also need to synchronize
> against console_trylock() callers. Since console_trylock() may
> be called from any context, the per-console mutex cannot be
> used for this synchronization. (mutex_trylock() cannot be
> called from atomic contexts.) Introduce a global atomic counter
> to identify if any threaded printers are active. The threaded
> printers will also check the atomic counter to identify if the
> console has been locked by another task via console_trylock().
>
> Note that @console_sem is still used to provide synchronization
> between console_lock() and console_trylock() callers.
>
> A locking overview for console_lock(), console_trylock(), and the
> threaded printers is as follows (pseudo code):
>
> console_lock()
> {
> down(&console_sem);
> for_each_console(con) {
> mutex_lock(&con->lock);
> con->flags |= CON_THD_BLOCKED;
> mutex_unlock(&con->lock);
> }
> /* console lock acquired */
> }
>
> console_trylock()
> {
> if (down_trylock(&console_sem) == 0) {
> if (atomic_cmpxchg(&console_kthreads_active, 0, -1) == 0) {
> /* console lock acquired */
> }
> }
> }
>
> threaded_printer()
> {
> mutex_lock(&con->lock);
> if (!(con->flags & CON_THD_BLOCKED)) {
> /* console_lock() callers blocked */
>
> if (atomic_inc_unless_negative(&console_kthreads_active)) {
> /* console_trylock() callers blocked */
>
> con->write();
>
> atomic_dec(&console_lock_count);
> }
> }
> mutex_unlock(&con->lock);
> }
>
> The console owner and waiter logic now only applies between contexts
> that have taken the console lock. Since threaded printers never take
> the console lock, they do not have a console lock to handover to
> other contexts.
>
> @panic_console_dropped must change to atomic_t since it is no longer
> protected exclusively by the console lock.
>
> Since threaded printers remain asleep if they see that the console
> is locked, they now must be explicitly woken in __console_unlock().
> This means wake_up_klogd() calls following a console_unlock() are
> no longer necessary and are removed.
BTW: I really like the commit message.
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -3230,7 +3335,11 @@ void register_console(struct console *newcon)
> if (newcon->flags & CON_EXTENDED)
> nr_ext_console_drivers++;
>
> + if (console_kthreads_blocked)
I think that this is actully always true because it is called under
console_lock().
> + newcon->flags |= CON_THD_BLOCKED;
> +
> newcon->dropped = 0;
> + mutex_init(&newcon->lock);
> if (newcon->flags & CON_PRINTBUFFER) {
> /* Get a consistent copy of @syslog_seq. */
> mutex_lock(&syslog_lock);
Best Regards,
Petr
next prev parent reply other threads:[~2022-04-08 13:52 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 13:25 [PATCH printk v2 00/12] implement threaded console printing John Ogness
2022-04-05 13:25 ` [PATCH printk v2 01/12] printk: rename cpulock functions John Ogness
2022-04-06 9:07 ` Petr Mladek
2022-04-05 13:25 ` [PATCH printk v2 02/12] printk: cpu sync always disable interrupts John Ogness
2022-04-05 13:25 ` [PATCH printk v2 03/12] printk: get caller_id/timestamp after migration disable John Ogness
2022-04-05 13:25 ` [PATCH printk v2 04/12] printk: call boot_delay_msec() in printk_delay() John Ogness
2022-04-05 13:25 ` [PATCH printk v2 05/12] printk: add macro for console detail messages John Ogness
2022-04-06 10:31 ` Petr Mladek
2022-04-05 13:25 ` [PATCH printk v2 06/12] printk: refactor and rework printing logic John Ogness
2022-04-06 14:02 ` Petr Mladek
2022-04-05 13:25 ` [PATCH printk v2 07/12] printk: move buffer definitions into console_emit_next_record() caller John Ogness
2022-04-06 14:40 ` Petr Mladek
2022-04-05 13:25 ` [PATCH printk v2 08/12] printk: add pr_flush() John Ogness
2022-04-06 15:17 ` Petr Mladek
2022-04-08 18:57 ` John Ogness
2022-04-05 13:25 ` [PATCH printk v2 09/12] printk: add functions to prefer direct printing John Ogness
2022-04-07 9:56 ` Petr Mladek
2022-04-07 13:35 ` Helge Deller
2022-04-07 14:35 ` John Ogness
2022-04-07 19:36 ` Helge Deller
2022-04-07 20:04 ` John Ogness
2022-04-07 20:20 ` Helge Deller
2022-04-11 12:50 ` Petr Mladek
2022-04-09 15:57 ` Paul E. McKenney
2022-04-05 13:25 ` [PATCH printk v2 10/12] printk: add kthread console printers John Ogness
2022-04-07 16:43 ` start/stop: was: " Petr Mladek
2022-04-07 16:49 ` console_is_usable() check: " Petr Mladek
2022-04-07 16:53 ` wake_up_klogd(): " Petr Mladek
2022-04-07 16:56 ` console_flush_all(): was: : was " Petr Mladek
2022-04-05 13:25 ` [PATCH printk v2 11/12] printk: extend console_lock for proper kthread support John Ogness
2022-04-08 13:45 ` guarantee forward progress: was: " Petr Mladek
2022-04-08 20:17 ` John Ogness
2022-04-11 10:45 ` Petr Mladek
2022-04-08 13:52 ` Petr Mladek [this message]
2022-04-05 13:25 ` [PATCH printk v2 12/12] printk: remove @console_locked John Ogness
2022-04-05 15:03 ` [PATCH printk v2 00/12] implement threaded console printing Andy Shevchenko
2022-04-05 21:24 ` John Ogness
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlA+JYC1ohU3LKuR@alley \
--to=pmladek@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).