From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Michael Walle" <michael@walle.cc>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
"Daniel Scally" <djrscally@gmail.com>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Len Brown" <lenb@kernel.org>, "Nuno Sá" <nuno.sa@analog.com>
Subject: Re: [PATCH v5 1/4] device property: Allow error pointer to be passed to fwnode APIs
Date: Fri, 8 Apr 2022 16:27:26 +0300 [thread overview]
Message-ID: <YlA4Pp11ZXG3eSX/@paasikivi.fi.intel.com> (raw)
In-Reply-To: <YlAuEzW0fUuuXTN6@smile.fi.intel.com>
Hi Andy,
On Fri, Apr 08, 2022 at 03:44:03PM +0300, Andy Shevchenko wrote:
> On Thu, Apr 07, 2022 at 01:19:44PM +0300, Andy Shevchenko wrote:
> > On Wed, Apr 06, 2022 at 08:05:23PM +0200, Michael Walle wrote:
>
> ...
>
> > > > + if (IS_ERR_OR_NULL(fwnode))
> > > > + return -ENOENT;
> > > > +
> > > > ret = fwnode_call_int_op(fwnode, get_reference_args, prop, nargs_prop,
> > > > nargs, index, args);
> > > > + if (ret == 0)
> > > > + return ret;
> > > >
> > > > - if (ret < 0 && !IS_ERR_OR_NULL(fwnode) &&
> > > > - !IS_ERR_OR_NULL(fwnode->secondary))
> > > > - ret = fwnode_call_int_op(fwnode->secondary, get_reference_args,
> > > > - prop, nargs_prop, nargs, index, args);
> > > > + if (IS_ERR_OR_NULL(fwnode->secondary))
> > > > + return -ENOENT;
> > >
> > > Doesn't this mean you overwrite any return code != 0 with -ENOENT?
> > > Is this intended?
> >
> > Indeed, it would shadow the error code.
>
> I was thinking more on this and am not sure about the best approach here.
> On one hand in the original code this returns the actual error code from
> the call against primary fwnode. But it can be at least -ENOENT or -EINVAL.
>
> But when we check the secondary fwnode we want to have understanding that it's
> secondary fwnode which has not been found, but this requires to have a good
> distinguishing between error codes from the callback.
>
> That said, the error codes convention of ->get_reference_args() simply
> sucks. Sakari, do you have it on your TODO to fix this mess out, if it's
> even feasible?
What would you expect to see compared to what it is now?
I guess the error code could be different for a missing property and a
property with invalid data, but I'm not sure any caller would be interested
in that.
>
> To be on safest side, I will change as suggested in previous mail (see below)
> so it won't have impact on -EINVAL case.
>
> > So, it should go with
> >
> > if (IS_ERR_OR_NULL(fwnode->secondary))
> > return ret;
> >
> > then.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
--
Sakari Ailus
next prev parent reply other threads:[~2022-04-08 13:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 13:05 [PATCH v5 1/4] device property: Allow error pointer to be passed to fwnode APIs Andy Shevchenko
2022-04-06 13:05 ` [PATCH v5 2/4] device property: Introduce fwnode_for_each_parent_node() Andy Shevchenko
2022-04-06 13:26 ` Sakari Ailus
2022-04-06 13:05 ` [PATCH v5 3/4] device property: Drop 'test' prefix in parameters of fwnode_is_ancestor_of() Andy Shevchenko
2022-04-06 13:05 ` [PATCH v5 4/4] device property: Constify fwnode APIs that uses fwnode_get_next_parent() Andy Shevchenko
2022-04-06 17:51 ` kernel test robot
2022-04-06 19:24 ` kernel test robot
2022-04-07 6:41 ` kernel test robot
2022-04-06 18:05 ` [PATCH v5 1/4] device property: Allow error pointer to be passed to fwnode APIs Michael Walle
2022-04-07 10:19 ` Andy Shevchenko
2022-04-08 12:44 ` Andy Shevchenko
2022-04-08 13:27 ` Sakari Ailus [this message]
2022-04-08 14:53 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlA4Pp11ZXG3eSX/@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=djrscally@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=nuno.sa@analog.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).