From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Carlos Bilbao <carlos.bilbao@amd.com>
Cc: bp@alien8.de, tglx@linutronix.de, mingo@redhat.com,
dave.hansen@linux.intel.com, x86@kernel.org,
linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
bilbao@vt.edu
Subject: Re: [PATCH 1/2] x86/mce: Simplify AMD severity grading logic
Date: Sun, 10 Apr 2022 13:04:44 +0000 [thread overview]
Message-ID: <YlLV7FKJZgrKOY9Z@yaz-ubuntu> (raw)
In-Reply-To: <20220405183212.354606-2-carlos.bilbao@amd.com>
On Tue, Apr 05, 2022 at 01:32:13PM -0500, Carlos Bilbao wrote:
...
> /*
> - * See AMD Error Scope Hierarchy table in a newer BKDG. For example
> - * 49125_15h_Models_30h-3Fh_BKDG.pdf, section "RAS Features"
> + * See AMD PPR(s) section Machine Check Error Handling
> */
This is now a single-line comment, so the /* */ should be adjusted. This is a
minor issue, so please wait for further review by others before sending
another revision, if needed.
Otherwise, the patch looks good to me.
Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>
Thanks!
-Yazen
next prev parent reply other threads:[~2022-04-10 13:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 18:32 [PATCH 0/2] x86/mce: Simplify AMD MCEs severity grading and include messages for panic cases Carlos Bilbao
2022-04-05 18:32 ` [PATCH 1/2] x86/mce: Simplify AMD severity grading logic Carlos Bilbao
2022-04-10 13:04 ` Yazen Ghannam [this message]
2022-04-25 15:56 ` [tip: ras/core] " tip-bot2 for Carlos Bilbao
2022-04-05 18:32 ` [PATCH 2/2] x86/mce: Add messages for panic errors in AMD's MCE grading Carlos Bilbao
2022-04-10 13:06 ` Yazen Ghannam
2022-04-25 15:56 ` [tip: ras/core] " tip-bot2 for Carlos Bilbao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlLV7FKJZgrKOY9Z@yaz-ubuntu \
--to=yazen.ghannam@amd.com \
--cc=bilbao@vt.edu \
--cc=bp@alien8.de \
--cc=carlos.bilbao@amd.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).