From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 787C4C433EF for ; Mon, 11 Apr 2022 09:16:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344303AbiDKJSk (ORCPT ); Mon, 11 Apr 2022 05:18:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237452AbiDKJSd (ORCPT ); Mon, 11 Apr 2022 05:18:33 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E90A2CC9D; Mon, 11 Apr 2022 02:16:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 88DBFB8118C; Mon, 11 Apr 2022 09:16:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A377C385A3; Mon, 11 Apr 2022 09:16:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649668571; bh=xisObcFJacVpSDNre/0NSb+BNa0t4nHTlVZpSFv1auw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dBIs6uqIbCd6a+kmttrcDqRKHOuazGnT4xsxgF5WYpv9e+B3fd7i8MfEv4OgkVnO9 7i+++kF7sHCouQ837msmSo5buiO4/FFkXxVpD4fU97zueHa58hpBQ8/rMa7Bsk/CtD Xq9u9rW4ppHiy54KvKJx8GwphBsSF7TqUQoUzbSc= Date: Mon, 11 Apr 2022 11:16:03 +0200 From: Greg KH To: Geert Uytterhoeven Cc: Laurent Vivier , Linux Kernel Mailing List , Alexandre Belloni , linux-m68k , Jiaxun Yang , linux-rtc@vger.kernel.org, Arnd Bergmann , Daniel Lezcano , John Stultz , Stephen Boyd , Thomas Gleixner , Alessandro Zummo , stable Subject: Re: [PATCH v16 1/4] tty: goldfish: introduce gf_ioread32()/gf_iowrite32() Message-ID: References: <20220406201523.243733-1-laurent@vivier.eu> <20220406201523.243733-2-laurent@vivier.eu> <198be9ea-a8c2-0f9e-6ae5-a7358035def4@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 11, 2022 at 10:53:39AM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Thu, Apr 7, 2022 at 8:18 AM Greg KH wrote: > > On Thu, Apr 07, 2022 at 08:00:08AM +0200, Laurent Vivier wrote: > > > Le 07/04/2022 à 06:48, Greg KH a écrit : > > > > On Wed, Apr 06, 2022 at 10:15:20PM +0200, Laurent Vivier wrote: > > > > > Revert > > > > > commit da31de35cd2f ("tty: goldfish: use __raw_writel()/__raw_readl()") > > > > > > > > > > and define gf_ioread32()/gf_iowrite32() to be able to use accessors > > > > > defined by the architecture. > > > > > > > > > > Cc: stable@vger.kernel.org # v5.11+ > > > > > Fixes: da31de35cd2f ("tty: goldfish: use __raw_writel()/__raw_readl()") > > > > > Signed-off-by: Laurent Vivier > > > > > Reviewed-by: Geert Uytterhoeven > > > > > --- > > > > > drivers/tty/goldfish.c | 20 ++++++++++---------- > > > > > include/linux/goldfish.h | 15 +++++++++++---- > > > > > 2 files changed, 21 insertions(+), 14 deletions(-) > > > > > > > > > > > > > Why is this a commit for the stable trees? What bug does it fix? You > > > > did not describe the problem in the changelog text at all, this looks > > > > like a housekeeping change only. > > > > > > Arnd asked for that in: > > > > > > Re: [PATCH v11 2/5] tty: goldfish: introduce gf_ioread32()/gf_iowrite32() > > > https://lore.kernel.org/lkml/CAK8P3a1oN8NrUjkh2X8jHQbyz42Xo6GSa=5n0gD6vQcXRjmq1Q@mail.gmail.com/ > > > > You did not provide a reason in this changelog to explain any of that :( > > OK if I queue that patch with the rationale from Arnd's email added > to the patch description? Fine with me, merge away!