From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ADCAC433EF for ; Tue, 12 Apr 2022 19:30:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358507AbiDLTct (ORCPT ); Tue, 12 Apr 2022 15:32:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245387AbiDLTck (ORCPT ); Tue, 12 Apr 2022 15:32:40 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 791CD3CFE2 for ; Tue, 12 Apr 2022 12:30:22 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id n18so17669356plg.5 for ; Tue, 12 Apr 2022 12:30:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=sKmZh3PaYY26BR+B2dRs/R9LlgovoIyv4Z/3LkpHaas=; b=JUDPn7fn8Rx3FHzUo35cOmXSzjdDkCl5t6mkLSekhksynwyH45KuNzU4S/KEOecSK4 EckijBrri7O1pTEPsDbxyPvQ1CN3SvrN65GC3o3ta+u7E0IkE/pSqbk4pf+tKmmHcUmo Jj6eBrapJ9GQGnSraNNGpgG8OyZeLzZZBzb/UcQYLDSZYAWXU8+VTjqsWoBfyYIPuFCd BPA6pQFyB6WluM0f1YcCaxEzvdzUYuGR3y8mfK6fyt8VuvP07i9h/X5kHLeE7xcCpniZ m3NvAY2ui3PGprmqlQGwxGxlOsfA0TxvuFtbimhYg8uLGB7c2B4jLjGyAE+bFK60sZ0O noWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sKmZh3PaYY26BR+B2dRs/R9LlgovoIyv4Z/3LkpHaas=; b=L+JSRGfMkPL+a4Se9tnBF/Bmy6Hk9/WlzlmzcC/NWWmEHEEoDhLo1bCekwhmk2ueBe /tPCoyQPqav9x21FSU2A2t/Xv4+Nqomd9PRCviHZQsQ6iHEDJNWvfgTdtQx5e2K3u2vK 1BTtXDENPMs6D89F/1gZBQoEGm1vYIHyvf9M9CyYg8i4X7hqApnAe3QQ36HFFLsbl1Kg wYP3FmiZWpuCDGmph8RqvhnkxnNnFpZGuOclkG3ROFZCLTnXaOJmu9n2GIP3hztw9PuT zbx/Q2b8AVMHGsS9pYH2LdFIipfga4LG3tBp+WziLsWQzHESzg+EpsgHEm7Xr0YVzdn6 kQMg== X-Gm-Message-State: AOAM533WiQmPBaVsBBZkCHjPQUq1hfMY+JA+ywCRy/xAGV8LkopPkaH6 LbDMlgqZuSUNJi1Nqr2svqx/TQ== X-Google-Smtp-Source: ABdhPJwl6pkdTRcJsFbNtPiE30Ma4FQuKKrig5lrk4zdsMcyG/04WVvZS5avSOgnQf2aam4QHX4kYA== X-Received: by 2002:a17:90a:4fa6:b0:1cb:1b77:c931 with SMTP id q35-20020a17090a4fa600b001cb1b77c931mr6773525pjh.63.1649791821808; Tue, 12 Apr 2022 12:30:21 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id q9-20020a056a00088900b004fe1a045e97sm28735604pfj.118.2022.04.12.12.30.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 12:30:21 -0700 (PDT) Date: Tue, 12 Apr 2022 19:30:17 +0000 From: Sean Christopherson To: Ben Gardon Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , Peter Xu , David Matlack , Jim Mattson , David Dunn , Jing Zhang , Junaid Shahid Subject: Re: [PATCH v2 7/9] KVM: x86/mmu: Add try_get_mt_mask to x86_ops Message-ID: References: <20220321224358.1305530-1-bgardon@google.com> <20220321224358.1305530-8-bgardon@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 11, 2022, Sean Christopherson wrote: > It's obviously not a hard dependency, but using a u64 for the mask here and then > undoing the whole thing is rather silly. Compile tested only at this point, I'll > test on an actual system ASAP and let you know if I did something stupid. > > From: Sean Christopherson > Date: Mon, 11 Apr 2022 15:12:16 -0700 > Subject: [PATCH] KVM: x86: Restrict get_mt_mask() to a u8, use > KVM_X86_OP_OPTIONAL_RET0 Verified this works as expected when patching in RET0 on a 32-bit kernel (returning a u64 results in reserved bits in the upper half being set due to EDX not being cleared).