From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v6 4/5] device property: Constify fwnode_handle_get()
Date: Wed, 13 Apr 2022 21:19:28 +0300 [thread overview]
Message-ID: <YlcUMNe5gDsEca4f@smile.fi.intel.com> (raw)
In-Reply-To: <CAJZ5v0jnyg6n-1QRmVg1tjzu3szsG3DYqYTXAbobbKwkFhTreg@mail.gmail.com>
On Wed, Apr 13, 2022 at 08:10:22PM +0200, Rafael J. Wysocki wrote:
> On Fri, Apr 8, 2022 at 8:49 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
...
> > -struct fwnode_handle *fwnode_handle_get(struct fwnode_handle *fwnode)
> > +struct fwnode_handle *fwnode_handle_get(const struct fwnode_handle *fwnode)
> > {
> > if (!fwnode_has_op(fwnode, get))
> > return fwnode;
^^^^, so it needs a casting, but then we have to comment why is so.
> Why is 0-day complaining about this one?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-04-13 18:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 18:48 [PATCH v6 1/5] device property: Allow error pointer to be passed to fwnode APIs Andy Shevchenko
2022-04-08 18:48 ` [PATCH v6 2/5] device property: Introduce fwnode_for_each_parent_node() Andy Shevchenko
2022-04-29 23:45 ` Doug Anderson
2022-04-08 18:48 ` [PATCH v6 3/5] device property: Drop 'test' prefix in parameters of fwnode_is_ancestor_of() Andy Shevchenko
2022-04-08 18:48 ` [PATCH v6 4/5] device property: Constify fwnode_handle_get() Andy Shevchenko
2022-04-08 21:36 ` Sakari Ailus
2022-04-10 14:10 ` Andy Shevchenko
2022-04-13 14:35 ` Sakari Ailus
2022-04-13 16:54 ` Andy Shevchenko
2022-04-13 18:21 ` Rafael J. Wysocki
2022-04-09 2:38 ` kernel test robot
2022-04-09 3:39 ` kernel test robot
2022-04-13 18:10 ` Rafael J. Wysocki
2022-04-13 18:19 ` Andy Shevchenko [this message]
2022-04-13 18:23 ` Andy Shevchenko
2022-04-13 21:47 ` Sakari Ailus
2022-04-14 13:09 ` Andy Shevchenko
2022-04-15 15:40 ` Rafael J. Wysocki
2022-04-08 18:48 ` [PATCH v6 5/5] device property: Constify fwnode APIs that uses fwnode_get_next_parent() Andy Shevchenko
2022-04-11 13:50 ` [PATCH v6 1/5] device property: Allow error pointer to be passed to fwnode APIs Andy Shevchenko
2022-04-11 14:28 ` Greg Kroah-Hartman
2022-04-11 15:46 ` Andy Shevchenko
2022-04-13 18:06 ` Rafael J. Wysocki
2022-04-13 18:20 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlcUMNe5gDsEca4f@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=djrscally@gmail.com \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).