From: Rob Herring <robh@kernel.org>
To: Cixi Geng <gengcixi@gmail.com>
Cc: mturquette@baylibre.com, sboyd@kernel.org, orsonzhai@gmail.com,
baolin.wang7@gmail.com, zhang.lyra@gmail.com,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: clk: sprd: add bindings for ums512 clock controller
Date: Wed, 13 Apr 2022 14:23:38 -0500 [thread overview]
Message-ID: <YlcjOmDAx6OAl+s0@robh.at.kernel.org> (raw)
In-Reply-To: <20220408104520.1896568-2-gengcixi@gmail.com>
On Fri, Apr 08, 2022 at 06:45:18PM +0800, Cixi Geng wrote:
> From: Cixi Geng <cixi.geng1@unisoc.com>
>
> add a new bindings to describe ums512 clock compatible string.
s/add a/Add/
>
> Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
> ---
> .../bindings/clock/sprd,ums512-clk.yaml | 100 ++++++++++++++++++
> 1 file changed, 100 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml
>
> diff --git a/Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml b/Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml
> new file mode 100644
> index 000000000000..a80bd6ca4a7a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml
> @@ -0,0 +1,100 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright 2022 Unisoc Inc.
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/clock/sprd,ums512-clk.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: UMS512 Clock Control Unit Device Tree Bindings
> +
> +maintainers:
> + - Orson Zhai <orsonzhai@gmail.com>
> + - Baolin Wang <baolin.wang7@gmail.com>
> + - Chunyan Zhang <zhang.lyra@gmail.com>
> +
> +properties:
> + "#clock-cells":
> + const: 1
> +
> + compatible:
> + enum:
> + - sprd,ums512-aon-gate
> + - sprd,ums512-apahb-gate
> + - sprd,ums512-apapb-gate
> + - sprd,ums512-audcpahb-gate
> + - sprd,ums512-audcpapb-gate
> + - sprd,ums512-g0-pll
> + - sprd,ums512-g2-pll
> + - sprd,ums512-g3-pll
> + - sprd,ums512-gc-pll
> + - sprd,ums512-gpu-clk
> + - sprd,ums512-mm-clk
> + - sprd,ums512-mm-gate-clk
> + - sprd,ums512-pmu-gate
> +
> + clocks:
> + minItems: 1
> + maxItems: 4
> + description: |
> + The input parent clock(s) phandle for this clock, only list fixed
> + clocks which are declared in devicetree.
> +
> + clock-names:
> + minItems: 1
> + items:
> + - const: ext-26m
> + - const: ext-32k
> + - const: ext-4m
> + - const: rco-100m
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - '#clock-cells'
> +
> +if:
> + properties:
> + compatible:
> + enum:
> + - sprd,ums512-ap-clk
> + - sprd,ums512-aonapb-clk
> +then:
> + required:
> + - reg
> +
> +else:
> + description: |
> + Other UMS512 clock nodes should be the child of a syscon node in
> + which compatible string should be:
> + "sprd,ums512-glbregs", "syscon", "simple-mfd"
This doesn't match your example.
> +
> + The 'reg' property for the clock node is also required if there is a sub
> + range of registers for the clocks.
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + ap_clk: clock-controller@20200000 {
> + compatible = "sprd,ums512-ap-clk";
> + reg = <0 0x20200000 0 0x1000>;
> + clocks = <&ext_26m>;
> + clock-names = "ext-26m";
> + #clock-cells = <1>;
> + };
> +
> + syscon@20100000{
> + compatible = "sprd,ums512-glbregs", "syscon","simple-mfd";
> + reg = <0 0x20100000 0 0x4000>;
> + clocks = <&ext_32k>, <&ext_26m>;
> + clock-names = "ext-32k", "ext-26m";
> + #clock-cells = <1>;
> + };
> + };
> +...
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2022-04-13 19:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 10:45 [PATCH 0/3] Add ums512 clocks and relative bindings file Cixi Geng
2022-04-08 10:45 ` [PATCH 1/3] dt-bindings: clk: sprd: add bindings for ums512 clock controller Cixi Geng
2022-04-13 19:23 ` Rob Herring [this message]
2022-04-08 10:45 ` [PATCH 2/3] clk: sprd: Add dt-bindings include file for UMS512 Cixi Geng
2022-04-13 19:24 ` Rob Herring
2022-04-08 10:45 ` [PATCH 3/3] clk: sprd: add clocks support " Cixi Geng
-- strict thread matches above, loose matches on Subject: below --
2021-09-15 9:09 [PATCH 1/3] dt-bindings: clk: sprd: Add bindings for ums512 clock controller Chunyan Zhang
2021-09-15 12:56 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlcjOmDAx6OAl+s0@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=baolin.wang7@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gengcixi@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=orsonzhai@gmail.com \
--cc=sboyd@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).