From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EFFAC433F5 for ; Thu, 14 Apr 2022 10:16:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242135AbiDNKS1 (ORCPT ); Thu, 14 Apr 2022 06:18:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242187AbiDNKSH (ORCPT ); Thu, 14 Apr 2022 06:18:07 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A08085468D; Thu, 14 Apr 2022 03:15:42 -0700 (PDT) Received: from zn.tnic (p2e55d808.dip0.t-ipconnect.de [46.85.216.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 2EF031EC05ED; Thu, 14 Apr 2022 12:15:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1649931337; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tcvILpawoy/EPkGkLSEhvv0Kdz440+lEpC25Pt/VCcQ=; b=BKlCWqNGE/Ep1cvt/qOcZSftYkpVpT+iOaYR+yPMnEQ2cHucqhZKpKdJv8W07gJQDPVYvY Dr8UoJLd4dHuOT55Ag1YvyTF/N5fAIOfsrgpfRzbWwcDBRa3ipPH5RrN/IQk8hzgpR6BuV 4zWAZ+lq9tJFmmI4yxAiLuAR+/7If2o= Date: Thu, 14 Apr 2022 12:15:37 +0200 From: Borislav Petkov To: Paul Menzel Cc: Medad Young , rric@kernel.org, James Morse , tony.luck@intel.com, Mauro Carvalho Chehab , Rob Herring , Benjamin Fair , Nancy Yuen , Patrick Venture , KWLIU@nuvoton.com, YSCHU@nuvoton.com, JJLIU0@nuvoton.com, KFTING , Avi Fishman , Tomer Maimon , Tali Perry , ctcchien@nuvoton.com, devicetree , OpenBMC Maillist , Linux Kernel Mailing List , linux-edac Subject: Re: [PATCH v6 3/3] EDAC: nuvoton: Add NPCM memory controller driver Message-ID: References: <20220322030152.19018-1-ctcchien@nuvoton.com> <20220322030152.19018-4-ctcchien@nuvoton.com> <14d07709-07ef-21a8-ad74-0f56447cf6dd@molgen.mpg.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <14d07709-07ef-21a8-ad74-0f56447cf6dd@molgen.mpg.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 14, 2022 at 10:56:43AM +0200, Paul Menzel wrote: > No idea, why you had to ask this question, while you statement before > already made the point. You've told Medad one thing. I told him the complete opposite. Medad as new submitter gets confused. And I don't want patch submitters to get confused by review. So, if you're unsure about a review feedback, don't give it pls. > Sorry I do not get your point. Would you elaborate on the debug message so > it’s more useful? Just think of the big picture: is my error message useful enough for debugging or would I have to go and add more info to it so that I can debug an issue? Example: There is edac_dbg(3, "InterruptStatus : 0x%x\n", intr_status); now. Now, how about this? edac_dbg(3, "dev: %s, id: %s: IRQ: %d, interrupt status: 0x%x\n", mci->dev_name, mci->ctl_name, irq, intr_status); Which one, do you think, is more helpful to a person trying to debug any potential issue with the interrupt handler and the ECCs it is supposed to issue? Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette