[PATCH 0/2] Disable MMIO tracing from QUP wrapper and serial driver

[PATCH 0/2] Disable MMIO tracing from QUP wrapper and serial driver

[Vijaya Krishna Nivarthi]

Register read/write tracing is causing excessive
logging and filling the rtb buffer and effecting
performance.

Disabled MMIO tracing from QUP wrapper and serial
driver to disable register read/write tracing.

Vijaya Krishna Nivarthi (2):
  soc: qcom: geni: Disable MMIO tracing
  tty: serial: qcom_geni_serial: Disable MMIO tracing

 drivers/soc/qcom/qcom-geni-se.c       | 8 +++++++-
 drivers/tty/serial/qcom_geni_serial.c | 8 +++++++-
 2 files changed, 14 insertions(+), 2 deletions(-)

-- 

[PATCH 1/2] soc: qcom: geni: Disable MMIO tracing

[Vijaya Krishna Nivarthi]

Register read/write tracing is causing excessive
logging and filling the rtb buffer and effecting
performance.

Disabled MMIO tracing to disable register
read/write tracing.

Signed-off-by: Visweswara Tanuku <quic_vtanuku@quicinc.com>
Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
---
 drivers/soc/qcom/qcom-geni-se.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c
index 28a8c0d..40e11c3 100644
--- a/drivers/soc/qcom/qcom-geni-se.c
+++ b/drivers/soc/qcom/qcom-geni-se.c
@@ -1,5 +1,11 @@
 // SPDX-License-Identifier: GPL-2.0
-// Copyright (c) 2017-2018, The Linux Foundation. All rights reserved.
+/*
+ * Copyright (c) 2017-2018, The Linux foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+/* Disable MMIO tracing */
+#define __DISABLE_TRACE_MMIO__
 
 #include <linux/acpi.h>
 #include <linux/clk.h>
-- 
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by the Linux Foundation.

[PATCH 2/2] tty: serial: qcom_geni_serial: Disable MMIO tracing

[Vijaya Krishna Nivarthi]

Register read/write tracing is causing excessive
logging and filling the rtb buffer and effecting
performance.

Disabled MMIO tracing to disable register
read/write tracing.

Signed-off-by: Visweswara Tanuku <quic_vtanuku@quicinc.com>
Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
---
 drivers/tty/serial/qcom_geni_serial.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
index f496102..aa8facb 100644
--- a/drivers/tty/serial/qcom_geni_serial.c
+++ b/drivers/tty/serial/qcom_geni_serial.c
@@ -1,5 +1,11 @@
 // SPDX-License-Identifier: GPL-2.0
-// Copyright (c) 2017-2018, The Linux foundation. All rights reserved.
+/*
+ * Copyright (c) 2017-2018, The Linux foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+/* Disable MMIO tracing */
+#define __DISABLE_TRACE_MMIO__
 
 #include <linux/clk.h>
 #include <linux/console.h>
-- 
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by the Linux Foundation.

Re: [PATCH 0/2] Disable MMIO tracing from QUP wrapper and serial driver

[Greg KH]

On Mon, May 02, 2022 at 04:15:12PM +0530, Vijaya Krishna Nivarthi wrote:
> Register read/write tracing is causing excessive
> logging and filling the rtb buffer and effecting
> performance.
> 
> Disabled MMIO tracing from QUP wrapper and serial
> driver to disable register read/write tracing.
> 
> Vijaya Krishna Nivarthi (2):
>   soc: qcom: geni: Disable MMIO tracing
>   tty: serial: qcom_geni_serial: Disable MMIO tracing
> 
>  drivers/soc/qcom/qcom-geni-se.c       | 8 +++++++-
>  drivers/tty/serial/qcom_geni_serial.c | 8 +++++++-
>  2 files changed, 14 insertions(+), 2 deletions(-)
> 
> -- 
> 

Doesn't this series depend on the MMIO tracing series?  Why not just
make it part of that one?

confused,

greg k-h

Re: [PATCH 1/2] soc: qcom: geni: Disable MMIO tracing

[Greg KH]

On Mon, May 02, 2022 at 04:15:13PM +0530, Vijaya Krishna Nivarthi wrote:
> Register read/write tracing is causing excessive
> logging and filling the rtb buffer and effecting
> performance.
> 
> Disabled MMIO tracing to disable register
> read/write tracing.
> 
> Signed-off-by: Visweswara Tanuku <quic_vtanuku@quicinc.com>
> Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
> ---
>  drivers/soc/qcom/qcom-geni-se.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c
> index 28a8c0d..40e11c3 100644
> --- a/drivers/soc/qcom/qcom-geni-se.c
> +++ b/drivers/soc/qcom/qcom-geni-se.c
> @@ -1,5 +1,11 @@
>  // SPDX-License-Identifier: GPL-2.0
> -// Copyright (c) 2017-2018, The Linux Foundation. All rights reserved.
> +/*
> + * Copyright (c) 2017-2018, The Linux foundation. All rights reserved.
> + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.

As stated before, I do not think this is a copyrightable change, and
will be glad to discuss that with your corporate lawyers if they insist.

thanks,

greg k-h

Re: [PATCH 2/2] tty: serial: qcom_geni_serial: Disable MMIO tracing

[Greg KH]

On Mon, May 02, 2022 at 04:15:14PM +0530, Vijaya Krishna Nivarthi wrote:
> Register read/write tracing is causing excessive
> logging and filling the rtb buffer and effecting
> performance.
> 
> Disabled MMIO tracing to disable register
> read/write tracing.
> 
> Signed-off-by: Visweswara Tanuku <quic_vtanuku@quicinc.com>
> Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
> ---
>  drivers/tty/serial/qcom_geni_serial.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
> index f496102..aa8facb 100644
> --- a/drivers/tty/serial/qcom_geni_serial.c
> +++ b/drivers/tty/serial/qcom_geni_serial.c
> @@ -1,5 +1,11 @@
>  // SPDX-License-Identifier: GPL-2.0
> -// Copyright (c) 2017-2018, The Linux foundation. All rights reserved.
> +/*
> + * Copyright (c) 2017-2018, The Linux foundation. All rights reserved.
> + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.

As stated before, this change is not proper.

thanks,

greg k-h

Re: [PATCH 0/2] Disable MMIO tracing from QUP wrapper and serial driver

[Sai Prakash Ranjan]

On 5/2/2022 5:36 PM, Greg KH wrote:
> On Mon, May 02, 2022 at 04:15:12PM +0530, Vijaya Krishna Nivarthi wrote:
>> Register read/write tracing is causing excessive
>> logging and filling the rtb buffer and effecting
>> performance.
>>
>> Disabled MMIO tracing from QUP wrapper and serial
>> driver to disable register read/write tracing.
>>
>> Vijaya Krishna Nivarthi (2):
>>    soc: qcom: geni: Disable MMIO tracing
>>    tty: serial: qcom_geni_serial: Disable MMIO tracing
>>
>>   drivers/soc/qcom/qcom-geni-se.c       | 8 +++++++-
>>   drivers/tty/serial/qcom_geni_serial.c | 8 +++++++-
>>   2 files changed, 14 insertions(+), 2 deletions(-)
>>
>> -- 
>>
> Doesn't this series depend on the MMIO tracing series?  Why not just
> make it part of that one?
>
> confused,
>
> greg k-h
>
>

It is already a part of MMIO tracing series - https://lore.kernel.org/lkml/cover.1651663123.git.quic_saipraka@quicinc.com/
There was some disconnect before but they have been informed. Now this series will be dropped and
will be taken as part of MMIO tracing series.

Thanks,
Sai