From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Emil Renner Berthing <kernel@esmil.dk>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: 8250: dw: Fix NULL pointer dereference
Date: Mon, 2 May 2022 15:12:53 +0300 [thread overview]
Message-ID: <Ym/KxaRfOaAS8Tzq@smile.fi.intel.com> (raw)
In-Reply-To: <20220502115621.77985-1-heikki.krogerus@linux.intel.com>
On Mon, May 02, 2022 at 02:56:21PM +0300, Heikki Krogerus wrote:
> dw8250_platform_data is only used on DT platforms for now.
Ah, good catch, Heikki!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thanks
> Fixes: 4a218b277fdb ("serial: 8250: dw: Create a generic platform data structure")
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> Hi,
>
> I'm sorry, I have to resend this (to you guys).
> I left out the mailing lists.
>
> Br,
> ---
> drivers/tty/serial/8250/8250_dw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
> index 0cf1a99dc1244..31422e44c64ff 100644
> --- a/drivers/tty/serial/8250/8250_dw.c
> +++ b/drivers/tty/serial/8250/8250_dw.c
> @@ -433,9 +433,9 @@ static void dw8250_prepare_rx_dma(struct uart_8250_port *p)
> static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data)
> {
> struct device_node *np = p->dev->of_node;
> - unsigned int quirks = data->pdata->quirks;
>
> if (np) {
> + unsigned int quirks = data->pdata->quirks;
> int id;
>
> /* get index of serial line, if found in DT aliases */
> --
> 2.35.1
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-05-02 12:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 11:56 [PATCH] serial: 8250: dw: Fix NULL pointer dereference Heikki Krogerus
2022-05-02 12:12 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ym/KxaRfOaAS8Tzq@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=kernel@esmil.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).