From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4A06C433F5 for ; Sat, 30 Apr 2022 16:48:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383186AbiD3QwL (ORCPT ); Sat, 30 Apr 2022 12:52:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383169AbiD3QwH (ORCPT ); Sat, 30 Apr 2022 12:52:07 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2142D98F43; Sat, 30 Apr 2022 09:48:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=dF1mmmBFDNP9HWUd+hs6Y1pIJYTO0dyqrecodlt1PlQ=; b=cPQi1qAZcGQGUaPBAA7ghyhZsu Kcj5E+qhh+Ka31F5l28xtkVKVJQ3WGtzmP+mAt3Y6l3OkZav8CDmsVKs26eQRc6xgABrD2gBmgQdz O/KxPtyROLauJBpg8XWEecq5bH+Q0Y6kq4adMNJrmbbRYSFsIZ3ilsdZK+dsnFTKkWv4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nkqGq-000eX6-Uo; Sat, 30 Apr 2022 18:48:36 +0200 Date: Sat, 30 Apr 2022 18:48:36 +0200 From: Andrew Lunn To: Peter Geis Cc: "Russell King (Oracle)" , Heiner Kallweit , "David S. Miller" , Jakub Kicinski , "open list:ARM/Rockchip SoC..." , Linux Kernel Network Developers , Linux Kernel Mailing List Subject: Re: [PATCH v1] net: phy: fix motorcomm module automatic loading Message-ID: References: <20220228233057.1140817-1-pgwipeout@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 30, 2022 at 12:31:27PM -0400, Peter Geis wrote: > On Sat, Apr 30, 2022 at 11:52 AM Andrew Lunn wrote: > > > > > Good Morning, > > > > > > After testing various configurations I found what is actually > > > happening here. When libphy is built in but the phy drivers are > > > modules and not available in the initrd, the generic phy driver binds > > > here. This allows the phy to come up but it is not functional. > > > > What MAC are you using? > > Specifically Motorcomm, but I've discovered it can happen with any of > the phy drivers with the right kconfig. > > > > > Why is you interface being brought up by the initramfs? Are you using > > NFS root from within the initramfs? > > This was discovered with embedded programming. It's common to have a > small initramfs, or forgo an initramfs altogether. Yes, i do that all the time. But then it is up to me to ensure i have all the code i need built into the kernel. > Another cause is a > mismatch in kernel config where phylib is built in because of a > dependency, but the rest of the phy drivers are modular. > The key is: > - phylib is built in > - ethernet driver is built in > - the phy driver is a module > - modules aren't available at probe time (for any reason). This 'for any reason' is what i'm trying to get at. It is not the kernel which builds the initramsfs. It is not the kernels problem if the modules it needs are missing, it is my fault for not telling the intramfs tools to include the modules needed to actually boot the machine. Andrew