From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44FB7C433EF for ; Mon, 2 May 2022 06:03:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383420AbiEBGHN (ORCPT ); Mon, 2 May 2022 02:07:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348929AbiEBGHK (ORCPT ); Mon, 2 May 2022 02:07:10 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 935504BB9A for ; Sun, 1 May 2022 23:03:40 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id v12so18228975wrv.10 for ; Sun, 01 May 2022 23:03:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4Wu5UbbLjO4fkVtRhATuGMYwwxjW91yZECIVVs3EXU0=; b=SCvBo61Id+dAqR8kqisUnDTJuBNQj7Vs0uVgzw/U9Quq+SsoF9gpIsUOLyajaPHVFL UGEXVCOvJgY5QKV17WRq/67bA3xhjSOhxEiS+1+2peE2irX76CoXN82/MBw1LgM6L5hD 2C02doNAqdL7lOsGzcA0nDSRdIIZZAAgULjF4iv9rK2JhCUHFzTvEIhbyGz4rAjMwNdC PL3i2q02XucjoePSxwqHT0XWq7hDq68pzo39J3oaUP6B9cwXCowSnIteVJbLzRdi4xzN wyhoJ43ogDBU4ZNUlbfcMv3DM/hNx/sp4o5HvQNon4W4REW++0v3SCCgS0aMf96kWfDz kAQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4Wu5UbbLjO4fkVtRhATuGMYwwxjW91yZECIVVs3EXU0=; b=zW3lfwNHRgByMqMPapXBfWoKvIhuphGoej+OQbJ/dg5Kyrxz5x/tuoPaCiGefmkBrj u1AFNgKK03YDhDMJRntEObi7l11ZBscZ9YJULP/KR4FIwxbW7JrIT3zFLQvkBMZqxeGe roE9Lds6Xl3KLLd/1owOnh/fs6lB+Ry1pwzsCgmmoNPUa+tpYba3dxXt8RdfzX9a7lMT HRoMeAjPiMi9CC14rZGZqWzbE8Ub7pGhiOTlK3fAsWBqxr+/dN/BrH6jnYoh0EC70sf2 6T5UD6mpylvqgbZoEl7Hb7aTaKtT4X4mQxDawvg+r6huhsPRpPj2dkXycsKCbZavC/IQ 69ZA== X-Gm-Message-State: AOAM533NFVRF8Jf8PafGllFgjZwiEsNaJn2KiVDHJDNVKt/d2Ohc9SiD +Eok1ssykMOLfzCGEDpHaFcprCX7d34MKm3W X-Google-Smtp-Source: ABdhPJwl/CgLhe01W0w1JZFddXPSEEwRbA3/K8E4VQg0z0/nxjTEpnDO3f469W8gdZ1CLEFJzCRw2g== X-Received: by 2002:a5d:64c8:0:b0:20c:6969:b277 with SMTP id f8-20020a5d64c8000000b0020c6969b277mr866262wri.354.1651471419059; Sun, 01 May 2022 23:03:39 -0700 (PDT) Received: from google.com (49.222.77.34.bc.googleusercontent.com. [34.77.222.49]) by smtp.gmail.com with ESMTPSA id y8-20020adfc7c8000000b0020c5253d902sm6212164wrg.78.2022.05.01.23.03.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 May 2022 23:03:38 -0700 (PDT) Date: Mon, 2 May 2022 06:03:37 +0000 From: Sebastian Ene To: Rob Herring Cc: linux-kernel@vger.kernel.org, Derek Kiernan , Dragan Cvetic , Arnd Bergmann , devicetree@vger.kernel.org, qperret@google.com, will@kernel.org, maz@kernel.org, Greg Kroah-Hartman , Guenter Roeck Subject: Re: [PATCH v4 0/2] Detect stalls on guest vCPUS Message-ID: References: <20220429083030.3241640-1-sebastianene@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 29, 2022 at 03:25:45PM -0500, Rob Herring wrote: > On Fri, Apr 29, 2022 at 08:30:29AM +0000, Sebastian Ene wrote: > > This adds a mechanism to detect stalls on the guest vCPUS by creating a > > per CPU hrtimer which periodically 'pets' the host backend driver. > > On a conventional watchdog-core driver, the userspace is responsible for > > delivering the 'pet' events by writing to the particular /dev/watchdogN node. > > In this case we require a strong thread affinity to be able to > > account for lost time on a per vCPU basis. > > > > This device driver acts as a soft lockup detector by relying on the host > > backend driver to measure the elapesed time between subsequent 'pet' events. > > If the elapsed time doesn't match an expected value, the backend driver > > decides that the guest vCPU is locked and resets the guest. The host > > backend driver takes into account the time that the guest is not > > running. The communication with the backend driver is done through MMIO > > and the register layout of the virtual watchdog is described as part of > > the backend driver changes. > > > > The host backend driver is implemented as part of: > > https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3548817 > > > > Changelog v4: > > - rename the source from vm-wdt.c -> vm-watchdog.c > > - convert all the error logging calls from pr_* to dev_* calls > > - rename the DTS node "clock" to "clock-frequency" Hi, > > Why do I have a v4 now when the discussion on v3 is not concluded. Give > folks some time to respond. We're busy drinking from the firehose. > I am trying to address the issues incrementlly keeping a week cadence. Any feedback on this is welcomed. Thanks, Seb > Rob