From: Herbert Xu <herbert@gondor.apana.org.au>
To: Corentin Labbe <clabbe@baylibre.com>
Cc: arno@natisbad.org, bbrezillon@kernel.org, schalla@marvell.com,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] crypto: marvell: cesa: Add fallback for handling empty length case
Date: Thu, 21 Apr 2022 17:50:57 +0800 [thread overview]
Message-ID: <YmEpAXymRIqoC6ur@gondor.apana.org.au> (raw)
In-Reply-To: <20220413191155.1429137-2-clabbe@baylibre.com>
On Wed, Apr 13, 2022 at 07:11:55PM +0000, Corentin Labbe wrote:
> The driver does not handle case where cryptlen is zero and fail crypto selftests.
> So let's add a fallback for this case.
Wouldn't it be easier to just handle this in the software? After
all, a zero encryption/decryption is just a no-op, right?
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2022-04-21 9:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 19:11 [PATCH 1/2] crypto: marvell: cesa: ECB does not IV Corentin Labbe
2022-04-13 19:11 ` [PATCH 2/2] crypto: marvell: cesa: Add fallback for handling empty length case Corentin Labbe
2022-04-21 9:50 ` Herbert Xu [this message]
2022-04-21 10:01 ` [PATCH 1/2] crypto: marvell: cesa: ECB does not IV Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmEpAXymRIqoC6ur@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=arno@natisbad.org \
--cc=bbrezillon@kernel.org \
--cc=clabbe@baylibre.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schalla@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).