From: Mike Rapoport <rppt@kernel.org>
To: David Hildenbrand <david@redhat.com>
Cc: Rebecca Mckeever <remckee0@gmail.com>,
outreachy@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] memblock tests: remove extra column of spaces in block comment
Date: Thu, 21 Apr 2022 17:42:40 +0300 [thread overview]
Message-ID: <YmFtYPlrJtv7iKh3@kernel.org> (raw)
In-Reply-To: <d46accec-28f7-d678-b475-c4402bba8211@redhat.com>
On Thu, Apr 21, 2022 at 09:09:58AM +0200, David Hildenbrand wrote:
> On 20.04.22 13:19, Rebecca Mckeever wrote:
> > Remove extra space at the beginning of each line in block comment
> > for consistency and to conform to Linux kernel coding style.
> >
> > Signed-off-by: Rebecca Mckeever <remckee0@gmail.com>
> > ---
> > tools/testing/memblock/tests/basic_api.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/tools/testing/memblock/tests/basic_api.c b/tools/testing/memblock/tests/basic_api.c
> > index 834d8705ff8a..05448a25f1f9 100644
> > --- a/tools/testing/memblock/tests/basic_api.c
> > +++ b/tools/testing/memblock/tests/basic_api.c
> > @@ -303,12 +303,12 @@ static int memblock_add_checks(void)
> > return 0;
> > }
> >
> > - /*
> > - * A simple test that marks a memory block of a specified base address
> > - * and size as reserved and to the collection of reserved memory regions
> > - * (memblock.reserved). Expect to create a new entry. The region counter
> > - * and total memory size are updated.
> > - */
> > +/*
> > + * A simple test that marks a memory block of a specified base address
> > + * and size as reserved and to the collection of reserved memory regions
> > + * (memblock.reserved). Expect to create a new entry. The region counter
> > + * and total memory size are updated.
> > + */
> > static int memblock_reserve_simple_check(void)
> > {
> > struct memblock_region *rgn;
>
> I'd pull this patch to the front, so you don't end up modifying a wrong
> style in patch #2. You could also just squash this patch into patch #2
> and mention it in the patch description.
Let's squash this into patch 2.
> --
> Thanks,
>
> David / dhildenb
>
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2022-04-21 14:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 11:18 [PATCH 0/3] memblock tests: update style of comments Rebecca Mckeever
2022-04-20 11:19 ` [PATCH 1/3] memblock tests: update style of comments for memblock_add_*() functions Rebecca Mckeever
2022-04-21 7:12 ` David Hildenbrand
2022-04-21 14:34 ` Mike Rapoport
2022-04-20 11:19 ` [PATCH 2/3] memblock tests: update style of comments for memblock_reserve_*() functions Rebecca Mckeever
2022-04-21 7:14 ` David Hildenbrand
2022-04-20 11:19 ` [PATCH 3/3] memblock tests: remove extra column of spaces in block comment Rebecca Mckeever
2022-04-21 7:09 ` David Hildenbrand
2022-04-21 14:42 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmFtYPlrJtv7iKh3@kernel.org \
--to=rppt@kernel.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=outreachy@lists.linux.dev \
--cc=remckee0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).