From: Matthew Wilcox <willy@infradead.org>
To: Nico Pache <npache@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Nicholas Piggin <npiggin@gmail.com>,
Logan Gunthorpe <logang@deltatee.com>,
Hari Bathini <hbathini@linux.ibm.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Yang Shi <shy828301@gmail.com>, Miaohe Lin <linmiaohe@huawei.com>,
William Kucharski <william.kucharski@oracle.com>,
Hugh Dickins <hughd@google.com>
Subject: Re: [RFC 1/3] mm: change vma_is_anonymous to vma_is_private_anon
Date: Thu, 21 Apr 2022 20:28:32 +0100 [thread overview]
Message-ID: <YmGwYKtz3sFkJlcv@casper.infradead.org> (raw)
In-Reply-To: <20220421190533.1601879-2-npache@redhat.com>
On Thu, Apr 21, 2022 at 03:05:31PM -0400, Nico Pache wrote:
> The vma_is_anonymous function isn't fully indicative of what it checks.
>
> Without having full knowledge of the mmap process, one may incorrectly
> assume this covers all types of anonymous memory; which is not the case.
Is your complaint that anonymous memory can also be found in file VMAs
that were mapped with MAP_PRIVATE? ie COWed pages?
I don't think renaming this function is appropriate. It's whether
the VMA is anonymous, not whether the VMA can contain anonymous
pages.
next prev parent reply other threads:[~2022-04-21 19:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 19:05 [RFC 0/3] Slight improvements for OOM/Futex Nico Pache
2022-04-21 19:05 ` [RFC 1/3] mm: change vma_is_anonymous to vma_is_private_anon Nico Pache
2022-04-21 19:28 ` Matthew Wilcox [this message]
2022-04-22 14:00 ` Nico Pache
2022-04-28 16:14 ` David Hildenbrand
2022-04-21 19:05 ` [RFC 2/3] futex: exit: Print a warning when futex_cleanup fails Nico Pache
2022-04-21 19:30 ` Matthew Wilcox
2022-04-22 14:12 ` Nico Pache
2022-04-21 20:53 ` Thomas Gleixner
2022-04-22 14:23 ` Nico Pache
2022-04-22 14:42 ` Thomas Gleixner
2022-04-21 19:05 ` [RFC 3/3] exit: Check for MMF_OOM_SKIP in exit_mmap Nico Pache
2022-04-22 15:38 ` Michal Hocko
2022-04-25 19:00 ` Nico Pache
2022-04-26 6:59 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmGwYKtz3sFkJlcv@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=hbathini@linux.ibm.com \
--cc=hughd@google.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=mpe@ellerman.id.au \
--cc=npache@redhat.com \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=shy828301@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).