From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Miroslav Benes <mbenes@suse.cz>,
Emil Velikov <emil.l.velikov@gmail.com>,
Jessica Yu <jeyu@kernel.org>, Quentin Perret <qperret@google.com>,
Matthias Maennich <maennich@google.com>
Subject: Re: [PATCH v2] export: fix string handling of namespace in EXPORT_SYMBOL_NS
Date: Wed, 27 Apr 2022 16:50:44 +0200 [thread overview]
Message-ID: <YmlYRMEzonSnwZ7q@kroah.com> (raw)
In-Reply-To: <CAK7LNASFK3z8Y=L1Q6uG3YZ2GBffBAASkc4tWfnPF__qeYh3SA@mail.gmail.com>
On Wed, Apr 27, 2022 at 11:29:19PM +0900, Masahiro Yamada wrote:
> On Wed, Apr 27, 2022 at 6:06 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > Commit c3a6cf19e695 ("export: avoid code duplication in
> > include/linux/export.h") broke the ability for a defined string to be
> > used as a namespace value.
>
> In hindsight, this was a bad idea.
>
>
> EXPORT_SYMBOL_NS_GPL(dw_spi_resume_host, "SPI_DW_CORE")
>
> is much much better than:
>
> EXPORT_SYMBOL_NS_GPL(dw_spi_resume_host, SPI_DW_CORE)
I agree, but it's really not that big of a deal. We could change it if
you want.
> ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE=USB_STORAGE
>
> is also a bad idea.
That's not such a bad idea as it lets you set a namespace for a
directory and below easily. What would you want to use instead?
> When you look at EXPORT_SYMBOL_GPL() in C files, you will not be
> aware of the presence of the namespace.
It's easy to tell when things do not link properly :)
> Anyway, it is presumably too late to fix it.
Not really, the number of in-kernel users are still small and can be
changed if you like. External users can update when they hit the change
as well, not a big deal.
Other than using a string for the namespace definition, what would you
like to see done differently?
> > Fix this up by using stringify to properly
> > encode the namespace name.
> >
> > Fixes: c3a6cf19e695 ("export: avoid code duplication in include/linux/export.h")
> > Cc: Miroslav Benes <mbenes@suse.cz>
> > Cc: Emil Velikov <emil.l.velikov@gmail.com>
> > Cc: Jessica Yu <jeyu@kernel.org>
> > Cc: Quentin Perret <qperret@google.com>
> > Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> This email is no longer valid.
Ah, sorry about that.
> Feel free to replace it with
>
> Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>
Will do, thanks!
greg k-h
next prev parent reply other threads:[~2022-04-27 14:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 9:04 [PATCH v2] export: fix string handling of namespace in EXPORT_SYMBOL_NS Greg Kroah-Hartman
2022-04-27 14:29 ` Masahiro Yamada
2022-04-27 14:50 ` Greg Kroah-Hartman [this message]
2022-04-27 15:11 ` Masahiro Yamada
2022-04-27 16:21 ` Greg Kroah-Hartman
2022-05-23 18:31 ` Masahiro Yamada
2022-05-24 8:10 ` Greg Kroah-Hartman
2022-05-31 7:44 ` Masahiro Yamada
2022-05-31 10:36 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmlYRMEzonSnwZ7q@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=emil.l.velikov@gmail.com \
--cc=jeyu@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maennich@google.com \
--cc=masahiroy@kernel.org \
--cc=mbenes@suse.cz \
--cc=qperret@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).