From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1E1BC4321E for ; Thu, 28 Apr 2022 09:19:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345197AbiD1JRl (ORCPT ); Thu, 28 Apr 2022 05:17:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345389AbiD1JPD (ORCPT ); Thu, 28 Apr 2022 05:15:03 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C7225DE40; Thu, 28 Apr 2022 02:11:49 -0700 (PDT) Date: Thu, 28 Apr 2022 11:11:46 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1651137108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nNOLzMN4GCAqBBfW+r8eqm5hDs3n5cjsSXnK/5QFPds=; b=q9fWvipxeyuuIhq4+NB4f0zZUeNRO9fKzRYos5WIhZ2FTHy8dYPMHVGR9bzNa3ITWgsq2J GqMGra6y+XiQ2aQl1i6HqvOofzVtblPQQe/dj5SbfpGTubLf0kTNg2rqcXkHFtoGFjfYah FOdw4duodfVpezANBfBJdprbLmZSXtsN77r9ambMrOqTOOcDrN/PBd8qGZjPyFsYKWU+Lu F9otqnAOa3RCZUVVm+f7geBY8fqswq1YvvsEZv0EipvwvgCwnY9ASCte0o0X80KAVIYABr u3P705AiBQ9FpbhbcZLHkPoiHWPDp5q61rGw597YAjo3wgVEOMtpqIwweRWW6A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1651137108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nNOLzMN4GCAqBBfW+r8eqm5hDs3n5cjsSXnK/5QFPds=; b=7dCD8xWto1maJxrNTxYG+xqLePiWvXHnBLrZmkaeDiRqei49ZmGnJxR9LO7zRcSbHpPRjy ep9UlPjhOTH1ebCQ== From: Sebastian Andrzej Siewior To: "Fabio M. De Francesco" Cc: Ira Weiny , Andrew Morton , Catalin Marinas , "Matthew Wilcox (Oracle)" , Will Deacon , Peter Collingbourne , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, outreachy@lists.linux.dev, Mike Rapoport Subject: Re: [PATCH v3 1/4] mm/highmem: Fix kernel-doc warnings in highmem*.h Message-ID: References: <20220427183821.1979-1-fmdefrancesco@gmail.com> <20220427183821.1979-2-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220427183821.1979-2-fmdefrancesco@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-04-27 20:38:18 [+0200], Fabio M. De Francesco wrote: > --- a/include/linux/highmem-internal.h > +++ b/include/linux/highmem-internal.h > @@ -236,9 +236,18 @@ static inline unsigned long totalhigh_pages(void) { = return 0UL; } > =20 > #endif /* CONFIG_HIGHMEM */ > =20 > -/* > - * Prevent people trying to call kunmap_atomic() as if it were kunmap() > - * kunmap_atomic() should get the return value of kmap_atomic, not the p= age. > +/** > + * kunmap_atomic - Unmap the virtual address mapped by kmap_atomic() - d= eprecated! > + * @__addr: Virtual address to be unmapped > + * > + * Unmaps an address previously mapped by kmap_atomic() and re-enables > + * pagefaults, migration, preemption (the latter was disabled only for > + * !PREEMP_RT configurations). Mappings should be unmapped in the reverse Not sure how detailed you want to put it here as "reverses kmap_atomic() doing." might be okay ;) This indicates the "migration" is disabled for !PREEMPT_RT which is not the case. So maybe something like * Unmaps an address previously mapped by kmap_atomic() and re-enables * pagefaults, CPU migration (CONFIG_PREEMPT_RT) or preemption * (!CONFIG_PREEMPT_RT). Mappings should be unmapped in the reverse will make it clear. =E2=80=A6 > --- a/include/linux/highmem.h > +++ b/include/linux/highmem.h > @@ -138,24 +138,14 @@ static inline void *kmap_local_folio(struct folio *= folio, size_t offset); > * > * Returns: The virtual address of the mapping > * > - * Effectively a wrapper around kmap_local_page() which disables pagefau= lts > - * and preemption. > + * In fact a wrapper around kmap_local_page() which disables pagefaults, > + * migration, preemption (the latter disabled only for !PREEMP_RT > + * configurations). and here. Sebastian