From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DFE2C433EF for ; Thu, 28 Apr 2022 17:28:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350532AbiD1Rbm (ORCPT ); Thu, 28 Apr 2022 13:31:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350510AbiD1Rbi (ORCPT ); Thu, 28 Apr 2022 13:31:38 -0400 Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D17DB45AC5 for ; Thu, 28 Apr 2022 10:28:23 -0700 (PDT) Received: by mail-qv1-xf36.google.com with SMTP id b17so3695149qvf.12 for ; Thu, 28 Apr 2022 10:28:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ywIQvVwgag1com6bDxPqmKMeB7A08MtYuevMsyOSOPQ=; b=8QDJnLhAmNHGsLaBQmDqBrcILYyDP9jv4WD9nDDyluZQ3AyEx3MdCGQSDqxW70SGO6 dHjEacPn670Cttc+vma5fsmybXQrEWDwOSriDm4M1zh/p8R0cfGR+P2UeAOOswBdPoPN UymIxmq005YN0pWaKnhy3Qt5T8fMP40inSpO/g4yKZyoeuGW2l3pub90YoPGUGQkiuLX cmUr1lNoAFW3vWIR6Ju6NmnMFVQlilVHADUJd9/Hwy6MK77xIUrA6Iyos41ScIK3y026 cbYAaiaMgarYe1E4TgstRbzWse+RFycZstcjBiJwinrr2bYwiHSWcfz1tz0VoDWKMy1B frzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ywIQvVwgag1com6bDxPqmKMeB7A08MtYuevMsyOSOPQ=; b=31xBM6fBnMw0wN5bTImKu7Y1b+gYAONCaZzoBvh2f0puxSAbNnARtm6RckCUOH/hki j1pz6LIkI9iHrwk1RygWMaJ1VNLl/cd22WGcon2aSjdYO/RAn8XEtrTJ59+OEfQWV7gT bThaeecriFQkS+DF5vQ4J8vRRZF2ecE92zpaY8gPHCEVrOj5RfjzqxRSdVqiicCN0+Jm rVB4IOTEsgpKmkjJPA7XpDwDKIewTmJG0Ua0Q3PBFw3PoiaGzktI+T7iC8raOH8S7PtH QUNnTmoYtKFBN9GCp/pKi1do2MTYbIRGin+mhiahR2DcQfOZOSyhrY6CFx5H8DYj2PHw 3XpA== X-Gm-Message-State: AOAM533uw+cnengI2NoOz2iBkRC+IMoPPsb6XQTUii69qUg7XZlubGDX rW+WKvwW1YKaU+F/rMn0B6ARyQ== X-Google-Smtp-Source: ABdhPJxRLZPBYQ+Renj2m3NAsWJcy1DxTlhIKkjU4+EhSPE4VL4dcK8UCxfEtZem5IKqTdfDjqjM5A== X-Received: by 2002:ad4:5f05:0:b0:456:306d:333d with SMTP id fo5-20020ad45f05000000b00456306d333dmr18665310qvb.16.1651166902753; Thu, 28 Apr 2022 10:28:22 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:d588]) by smtp.gmail.com with ESMTPSA id 15-20020ac8594f000000b002f200ea2518sm327527qtz.59.2022.04.28.10.28.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Apr 2022 10:28:22 -0700 (PDT) Date: Thu, 28 Apr 2022 13:27:46 -0400 From: Johannes Weiner To: Minchan Kim Cc: Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , Seth Jennings , Dan Streetman , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 4/5] mm: zswap: add basic meminfo and vmstat coverage Message-ID: References: <20220427160016.144237-1-hannes@cmpxchg.org> <20220427160016.144237-5-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 28, 2022 at 10:02:46AM -0700, Minchan Kim wrote: > On Thu, Apr 28, 2022 at 10:05:13AM -0400, Johannes Weiner wrote: > > But I'd ack a patch that adds a combined "Compressed" counter for zram > > + zswap if you send it, Minchan. > > If we really want to go separate stat for zswap and zram, it would > be better to use direct name "Zram: " instead of comrpessed. That works for me as well.