From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Parshuram Raju Thombare <pthombar@cadence.com>,
tjoseph@cadence.com, bhelgaas@google.com, robh@kernel.org,
kishon@ti.com, kw@linux.com, mparab@cadence.com,
linux-pci@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] PCI: cadence: Clear FLR in device capabilities register
Date: Thu, 12 May 2022 22:23:09 +0100 [thread overview]
Message-ID: <Yn16vX1cGMt0CVj6@lpieralisi> (raw)
In-Reply-To: <20220512190626.GA862290@bhelgaas>
On Thu, May 12, 2022 at 02:06:26PM -0500, Bjorn Helgaas wrote:
> On Wed, May 11, 2022 at 05:02:35PM +0100, Lorenzo Pieralisi wrote:
> > On Mon, 15 Nov 2021 23:39:16 -0800, Parshuram Raju Thombare wrote:
> > > From: Parshuram Thombare <pthombar@cadence.com>
> > >
> > > Clear FLR (Function Level Reset) from device capabilities
> > > registers for all physical functions.
> > >
> > > During FLR, the Margining Lane Status and Margining Lane Control
> > > registers should not be reset, as per PCIe specification.
> > > However, the controller incorrectly resets these registers upon FLR.
> > > This causes PCISIG compliance FLR test to fail. Hence preventing
> > > all functions from advertising FLR support if flag quirk_disable_flr
> > > is set.
> > >
> > > [...]
> >
> > Applied to pci/cadence, thanks!
> >
> > [1/1] PCI: cadence: Clear FLR in device capabilities register
> > https://git.kernel.org/lpieralisi/pci/c/d3dbd4d862
>
> Obviously you've already seen the kbuild report:
> https://lore.kernel.org/r/202205120700.X76G7aC2-lkp@intel.com
>
> but it looks like most of this patch got lost somehow :) Happy to fix
> it up for you if you want!
I have messed up the merge, now rebuilt my pci/cadence branch, it
_should_ be fixed, apologies.
Lorenzo
next prev parent reply other threads:[~2022-05-12 21:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 7:39 [PATCH v2] PCI: cadence: Clear FLR in device capabilities register Parshuram Raju Thombare
2021-12-13 14:26 ` Parshuram Raju Thombare
2022-05-11 16:02 ` Lorenzo Pieralisi
2022-05-12 19:06 ` Bjorn Helgaas
2022-05-12 21:23 ` Lorenzo Pieralisi [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-10-25 12:31 Parshuram Raju Thombare
2021-10-25 12:44 ` Parshuram Raju Thombare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yn16vX1cGMt0CVj6@lpieralisi \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=kishon@ti.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mparab@cadence.com \
--cc=pthombar@cadence.com \
--cc=robh@kernel.org \
--cc=tjoseph@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).