From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Pablo Ceballos <pceballos@google.com>
Cc: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
lkml <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH] HID: Driver for Google Hangouts Meet Speakermic
Date: Fri, 13 May 2022 00:47:49 +0200 [thread overview]
Message-ID: <Yn2OlQAa9I++N80B@penguin> (raw)
In-Reply-To: <CAO9JgFwA5ZhwOOY0cU3HpMOV69CTumQ50zEgU6SPNAF0zDbCGg@mail.gmail.com>
On Thu, May 12, 2022 at 03:35:00PM -0700, Pablo Ceballos wrote:
> On Thu, May 12, 2022 at 3:53 AM Jiri Kosina <jikos@kernel.org> wrote:
> > On Thu, 12 May 2022, Dmitry Torokhov wrote:
> > > I am curious, could not this be achieved without a kernel driver by
> > > simply using udev to map this usage code to KEY_RESERVED?
> >
> > Hmm, good point, using KEY_RESERVED mapping to achieve the key being
> > actually ignored didn't immediately occur to me.
> >
> > Pablo, could you please verify that it behaves in the expected way, and
> > confirm that we could drop the 'driver' in favor of udev rule?
>
> I think I've achieved the same result by adding the following to udev
> hwdb. Dmitry, is this what you had in mind, or is there a better way
> of doing this?
>
> evdev:input:b0003v18D1p8001*
> KEYBOARD_KEY_b002f=reserved
No, that is exactly what I had in mind, thank you. Please submit this
entry to upstream systemd/udev project (and we can cherry-pick it into
our udev as well).
In general I think we should try to avoid trivial "fixup" HID drivers if
it is possible. I also wondered if we could be supplying fixed-up HID
descriptors via request_firmware() for HID devices.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2022-05-12 22:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 18:39 [PATCH] HID: Driver for Google Hangouts Meet Speakermic Pablo Ceballos
2022-04-12 22:20 ` Pablo Ceballos
2022-04-21 7:48 ` Jiri Kosina
2022-05-12 9:34 ` Dmitry Torokhov
2022-05-12 10:53 ` Jiri Kosina
2022-05-12 22:35 ` Pablo Ceballos
2022-05-12 22:47 ` Dmitry Torokhov [this message]
2022-05-16 15:03 ` Pablo Ceballos
2022-05-16 18:23 ` Benjamin Tissoires
2022-05-22 15:05 ` Pavel Machek
2022-05-23 6:50 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yn2OlQAa9I++N80B@penguin \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pceballos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).