From: kernel test robot <lkp@intel.com>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: kbuild-all@lists.01.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [RFC PATCH pdx86-platform-drivers-x86] platform/x86: thinkpad_acpi: quirk_btusb_bug can be static
Date: Tue, 3 May 2022 19:18:05 +0800 [thread overview]
Message-ID: <YnEPbSO2rBJq37Ez@74ccfaeec2ea> (raw)
In-Reply-To: <202205031944.EP1ElC1B-lkp@intel.com>
drivers/platform/x86/thinkpad_acpi.c:317:20: warning: symbol 'quirk_btusb_bug' was not declared. Should it be static?
Fixes: 25eecc2ff6cc ("platform/x86: thinkpad_acpi: Convert btusb DMI list to quirks")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
drivers/platform/x86/thinkpad_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index aed17d32ed84b..eefa22e86ae10 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -314,7 +314,7 @@ struct quirk_entry {
bool btusb_bug;
};
-struct quirk_entry quirk_btusb_bug = {
+static struct quirk_entry quirk_btusb_bug = {
.btusb_bug = true,
};
next prev parent reply other threads:[~2022-05-03 11:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 11:27 [pdx86-platform-drivers-x86:review-hans 30/32] drivers/platform/x86/thinkpad_acpi.c:317:20: sparse: sparse: symbol 'quirk_btusb_bug' was not declared. Should it be static? kernel test robot
2022-05-03 11:18 ` kernel test robot [this message]
2022-05-03 13:07 ` [RFC PATCH pdx86-platform-drivers-x86] platform/x86: thinkpad_acpi: quirk_btusb_bug can be static Limonciello, Mario
2022-05-06 10:09 ` Hans de Goede
2022-05-06 11:07 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnEPbSO2rBJq37Ez@74ccfaeec2ea \
--to=lkp@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).