From: Mark Brown <broonie@kernel.org>
To: Kalesh Singh <kaleshsingh@google.com>
Cc: mark.rutland@arm.com, will@kernel.org, maz@kernel.org,
qperret@google.com, tabba@google.com, surenb@google.com,
kernel-team@android.com, James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Peter Collingbourne <pcc@google.com>,
Alexei Starovoitov <ast@kernel.org>,
"Madhavan T. Venkataraman" <madvenka@linux.microsoft.com>,
Andrew Jones <drjones@redhat.com>, Marco Elver <elver@google.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Keir Fraser <keirf@google.com>, Zenghui Yu <yuzenghui@huawei.com>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/5] KVM: arm64: Compile stacktrace.nvhe.o
Date: Wed, 4 May 2022 15:16:56 +0100 [thread overview]
Message-ID: <YnKK2IxdbVvcsOC2@sirena.org.uk> (raw)
In-Reply-To: <20220502191222.4192768-3-kaleshsingh@google.com>
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
On Mon, May 02, 2022 at 12:12:02PM -0700, Kalesh Singh wrote:
> Recompile stack unwinding code for use with the nVHE hypervisor. This is
> a preparatory patch that will allow reusing most of the kernel unwinding
> logic in the nVHE hypervisor.
> enum stack_type {
> - STACK_TYPE_UNKNOWN,
> +#ifndef __KVM_NVHE_HYPERVISOR__
> STACK_TYPE_TASK,
> STACK_TYPE_IRQ,
> STACK_TYPE_OVERFLOW,
> STACK_TYPE_SDEI_NORMAL,
> STACK_TYPE_SDEI_CRITICAL,
> +#endif /* !__KVM_NVHE_HYPERVISOR__ */
> + STACK_TYPE_UNKNOWN,
> __NR_STACK_TYPES
> };
I don't immediately see a problem with it but I'm curious as to why
STACK_TYPE_UNKNOWN got moved to the end of the list here? It does mean
that zeroed memory will default to STACK_TYPE_TASK but we're not
actually relying on that. Otherwise
Reviwed-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-05-04 14:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 19:12 [PATCH v2 0/5] KVM nVHE Hypervisor stack unwinder Kalesh Singh
2022-05-02 19:12 ` [PATCH v2 1/5] KVM: arm64: Factor out common stack unwinding logic Kalesh Singh
2022-05-04 13:41 ` Mark Brown
2022-05-02 19:12 ` [PATCH v2 2/5] KVM: arm64: Compile stacktrace.nvhe.o Kalesh Singh
2022-05-04 14:16 ` Mark Brown [this message]
2022-05-04 16:02 ` Kalesh Singh
2022-05-02 19:12 ` [PATCH v2 3/5] KVM: arm64: Add hypervisor overflow stack Kalesh Singh
2022-05-02 19:12 ` [PATCH v2 4/5] KVM: arm64: Allocate shared stacktrace pages Kalesh Singh
2022-05-02 19:12 ` [PATCH v2 5/5] KVM: arm64: Unwind and dump nVHE hypervisor stacktrace Kalesh Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnKK2IxdbVvcsOC2@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexandru.elisei@arm.com \
--cc=ast@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=drjones@redhat.com \
--cc=elver@google.com \
--cc=james.morse@arm.com \
--cc=kaleshsingh@google.com \
--cc=keirf@google.com \
--cc=kernel-team@android.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madvenka@linux.microsoft.com \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mhiramat@kernel.org \
--cc=pcc@google.com \
--cc=qperret@google.com \
--cc=surenb@google.com \
--cc=suzuki.poulose@arm.com \
--cc=tabba@google.com \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).