linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Lecopzer Chen <lecopzer.chen@mediatek.com>
Cc: linux-kernel@vger.kernel.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-modules@vger.kernel.org,
	linux-mediatek@lists.infradead.org, yj.chiang@mediatek.com,
	atomlin@redhat.com
Subject: Re: [RESEND PATCH] module: show disallowed symbol name for inherit_taint()
Date: Wed, 4 May 2022 13:48:11 -0700	[thread overview]
Message-ID: <YnLmi26EBEFJM5aH@bombadil.infradead.org> (raw)
In-Reply-To: <20220427073606.29752-1-lecopzer.chen@mediatek.com>

On Wed, Apr 27, 2022 at 03:36:06PM +0800, Lecopzer Chen wrote:
> The error log for inherit_taint() doesn't really help to find the
> symbol which violates GPL rules.
> 
> For example,
> if a module has 300 symbol and includes 50 disallowed symbols,
> the log only shows the content below and we have no idea what symbol is.
>     AAA: module using GPL-only symbols uses symbols from proprietary module BBB.
> 
> It's hard for user who doesn't really know how the symbol was parsing.
> 
> This patch add symbol name to tell the offending symbols explicitly.
>     AAA: module using GPL-only symbols uses symbols SSS from proprietary module BBB.
> 
> Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>

Thanks, pushed onto modules-testing. If there are no issues I'll
eventually push this onto modules-next.

  Luis

      reply	other threads:[~2022-05-04 20:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27  7:36 [RESEND PATCH] module: show disallowed symbol name for inherit_taint() Lecopzer Chen
2022-05-04 20:48 ` Luis Chamberlain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YnLmi26EBEFJM5aH@bombadil.infradead.org \
    --to=mcgrof@kernel.org \
    --cc=atomlin@redhat.com \
    --cc=lecopzer.chen@mediatek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=yj.chiang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).