From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68301C4332F for ; Wed, 4 May 2022 23:45:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382164AbiEDXrc (ORCPT ); Wed, 4 May 2022 19:47:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380372AbiEDX3U (ORCPT ); Wed, 4 May 2022 19:29:20 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46E774F9F8; Wed, 4 May 2022 16:25:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=Jh0E5X0iydVvkz7XqNrDyD+rBDluF5khygQc2zdVasw=; b=EvCZKuuhsTlJaKl2Vmdl8pM0xU Xm6OH+num05/am++VP2ysYeco2LkZanxFlNdXyN9Sqp2W4gkHhZrozisTu/ECfE6teJ30HRZCZVJL ILLlqmAIwrUEr0nudRKMSvuxUB3ZC65hJe6C4CGuBWnQqQgpqmpb6aYL63cx/AnLB024=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nmON9-001HHB-RH; Thu, 05 May 2022 01:25:31 +0200 Date: Thu, 5 May 2022 01:25:31 +0200 From: Andrew Lunn To: Ansuel Smith Cc: Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Pavel Machek , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [RFC PATCH v6 03/11] leds: trigger: netdev: drop NETDEV_LED_MODE_LINKUP from mode Message-ID: References: <20220503151633.18760-1-ansuelsmth@gmail.com> <20220503151633.18760-4-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220503151633.18760-4-ansuelsmth@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 03, 2022 at 05:16:25PM +0200, Ansuel Smith wrote: > Drop NETDEV_LED_MODE_LINKUP from mode list and convert to a simple bool > that will be true or false based on the carrier link. No functional > change intended. What is missing from the commit message is an explanation why? Andrew