From: Matthew Wilcox <willy@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [GIT PULL] Two folio fixes for 5.18
Date: Fri, 6 May 2022 00:43:18 +0100 [thread overview]
Message-ID: <YnRhFrLuRM5SY+hq@casper.infradead.org> (raw)
Darrick and Brian have done amazing work debugging the race I created
in the folio BIO iterator. The readahead problem was deterministic,
so easy to fix.
The following changes since commit a7391ad3572431a354c927cf8896e86e50d7d0bf:
Merge tag 'iomm-fixes-v5.18-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu (2022-05-04 11:04:52 -0700)
are available in the Git repository at:
git://git.infradead.org/users/willy/pagecache.git tags/folio-5.18f
for you to fetch changes up to b9ff43dd27434dbd850b908e2e0e1f6e794efd9b:
mm/readahead: Fix readahead with large folios (2022-05-05 00:47:29 -0400)
----------------------------------------------------------------
Two folio fixes for 5.18:
- Fix a race when we were calling folio_next() in the BIO folio iter
without holding a reference, meaning the folio could be split or freed,
and we'd jump to the next page instead of the intended next folio.
- Fix readahead creating single-page folios instead of the intended
large folios when doing reads that are not a power of two in size.
----------------------------------------------------------------
Matthew Wilcox (Oracle) (2):
block: Do not call folio_next() on an unreferenced folio
mm/readahead: Fix readahead with large folios
include/linux/bio.h | 5 ++++-
mm/readahead.c | 15 +++++++++------
2 files changed, 13 insertions(+), 7 deletions(-)
next reply other threads:[~2022-05-05 23:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 23:43 Matthew Wilcox [this message]
2022-05-06 0:02 ` [GIT PULL] Two folio fixes for 5.18 pr-tracker-bot
2022-05-10 22:18 ` Andrew Morton
2022-05-10 22:30 ` Matthew Wilcox
2022-05-10 22:45 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnRhFrLuRM5SY+hq@casper.infradead.org \
--to=willy@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).