From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66029C433FE for ; Fri, 6 May 2022 00:48:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1387646AbiEFAvr (ORCPT ); Thu, 5 May 2022 20:51:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1387637AbiEFAvq (ORCPT ); Thu, 5 May 2022 20:51:46 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D80324595 for ; Thu, 5 May 2022 17:48:04 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id t13so4883512pgn.8 for ; Thu, 05 May 2022 17:48:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8H1hD0Mt9l4w14U4/SRoh7xqynrycl1d7ruNMYrGOXM=; b=VeVpMWh2cjKV3lc2nH/KPSCCrD/CGkL2HT5V4Ze0aYcftc9PaqEcjOXNEkCPOnn37W O0d81fmemvgKLerZwNPXfAA+7gfSVWT/KBaP0F5CjmpCNvLsBxN2uRmbtHalNy+JtT/I K85/XCX3VTHgWWLcNV0AhOe5pGmHmSucCbsnM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8H1hD0Mt9l4w14U4/SRoh7xqynrycl1d7ruNMYrGOXM=; b=ELz5+rarwToYN3EwUc7xrx9Z8q22OrzDrEkb3SEZr55fdKupBKrEeaT+FNh6PoLuvo Y+Cy4J6LY9+BEt/GVKMK/LD2ikor7UgHAbH7M1RrSaWwwGgLKaSKAWAgy0kPT9ajHere yO963C8IO3RPP/zzIOumHLCjz9tGU47YB9dD42SX+K5Qj5jxg5XBe2QQqRdqblpAsNUo F/RKsVDW+a9wcVgEL+9qsILItCY1qy6QMEqXA9ZMsmGPVaXjNzkhLITSy4bREb1V94wo rB2oQjZb4clVkTNQLzPS6f9IIGWT449ykgarxMuAcRtNiPvJS5X9EA7EpWg7C4onecck +c/A== X-Gm-Message-State: AOAM532cgI3VyJPtKHpja+GCDgdnPpkDX8pkyriDEu8F/YyOQzuEKOs/ CyErmmtV5JNOb8NhPJt7K+taIQ== X-Google-Smtp-Source: ABdhPJx3sbhEjKzbUXWsBF0Is48l4gQcbyDGHkecwlZSvN3GylD2Q8p9Mpri/WVTo3olKHcUfnr+BQ== X-Received: by 2002:a63:4101:0:b0:3aa:6375:e5f4 with SMTP id o1-20020a634101000000b003aa6375e5f4mr679533pga.240.1651798083634; Thu, 05 May 2022 17:48:03 -0700 (PDT) Received: from localhost ([2620:15c:202:201:5605:d5cd:699b:1b26]) by smtp.gmail.com with UTF8SMTPSA id s13-20020a170902988d00b0015e8d4eb257sm237220plp.161.2022.05.05.17.48.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 May 2022 17:48:03 -0700 (PDT) Date: Thu, 5 May 2022 17:48:02 -0700 From: Matthias Kaehlcke To: Douglas Anderson Cc: Bjorn Andersson , swboyd@chromium.org, Andy Gross , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: qcom: sc7280: Set SPI flash to 50 MHz for herobrine boards Message-ID: References: <20220505161425.1.Icf6f3796d2fa122b4c0566d9317b461bfbc24b7f@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220505161425.1.Icf6f3796d2fa122b4c0566d9317b461bfbc24b7f@changeid> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 05, 2022 at 04:14:30PM -0700, Douglas Anderson wrote: > sc7280-herobrine based boards are specced to be able to access their > SPI flash at 50 MHz with the drive strength of the pins set at 8. The > drive strength is already set to 8 in "sc7280-herobrine.dtsi", so > let's bump up the clock. The matching firmware change for this is at: > > https://review.coreboot.org/c/coreboot/+/63948 > > NOTE: the firmware change isn't _required_ to make the kernel work at > 50 MHz, it merely shows that the boards are known to work fine at 50 > MHz. > > ALSO NOTE: this doesn't update the "sc7280-chrome-common.dtsi" file > which is used by both herobrine boards and IDP. At the moment the IDP > boards aren't configuring a drive strength of 8 and it seems safer to > just leave them at the slower speed if they're already working. > > Signed-off-by: Douglas Anderson Reviewed-by: Matthias Kaehlcke