From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F79FC433FE for ; Fri, 6 May 2022 03:16:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355556AbiEFDU1 (ORCPT ); Thu, 5 May 2022 23:20:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1388465AbiEFDUZ (ORCPT ); Thu, 5 May 2022 23:20:25 -0400 Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B35BB1A816 for ; Thu, 5 May 2022 20:16:43 -0700 (PDT) Received: by mail-oi1-x229.google.com with SMTP id m11so6298902oib.11 for ; Thu, 05 May 2022 20:16:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XDAab3lFiT4oWPvDdIok5sqYK5jSVOc29GloIg/CLzs=; b=M0srnKgPkJySL8mZ86biFhA5OuOllZTy3Ykf2nF4IdVq0ZwcscLBqGUA2U9AYumHGC QgDx8Dj5zZYal/OguV/5ygwsWART5MfMI2creJnrsp7adnbljV7xcHcNb0Eml0GJur8w RsSJyeZ+SEp0oSdN37ulcoQbqr6ZnqVdB/5BifgK06CbNLcbO6F5U8qbKi/XHQ0bRAN9 aa3q5QuIP8Zl0+7zKYErOrsUgpMXI0+Q4+eNJYrIPVthdQ59EbaZ/rCYwUpy1+WOJ/fj YeZkTnppN78qT2LhPEpvrOIuaeezbKNaqoYkBJ7MDualrT1EQ5xskORqitfbRofS8yRY Z3kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XDAab3lFiT4oWPvDdIok5sqYK5jSVOc29GloIg/CLzs=; b=GHewQKvmukx8sEL6KuU0WVuA+XuZdIjHWZE6oDEIKHWzp1i9MJYYQbbeoaohkROXjr uOccOPN6B/k4ArhwE0e/uCGHX8mOTIqHg3MXxGNnlzmpIxioFSWNs0M2S13b+pyROuWr a8XF4vgkJvx6vC3BvUSBB6TpNYx3a39KKH/0/FYodW6XUweIutjNkoth/2bAwhnKy18l OtFBebQ4qLUN6JydbiUdjVNFBisDCHrFRevboPSDKpgUXOF6Rdxpq/KSm2W1h3Ar9p0g VkGntjDSeOuOHJFd91WOByiz0hydc80YwBQh3lyyxjOpY90OZp59XpA+g95smSzOe3BJ fIfA== X-Gm-Message-State: AOAM533d7/Q+46cMwrQRXXbaD2NwzIVXmcjCLXMnMdX6Q/ZIRU8jYXpR 7UJkb1So5Y9IQRdZxtFwylIosDkNhYRcQcjZ X-Google-Smtp-Source: ABdhPJyGhZMLU7kovwSB7RSCQTNkWr5ruVjbo0AhP9QogwaAMX2QH+ktw7ZhWEoESJ3wrYu7cDt7ng== X-Received: by 2002:a05:6808:92:b0:325:bdf6:f824 with SMTP id s18-20020a056808009200b00325bdf6f824mr4089983oic.147.1651807003107; Thu, 05 May 2022 20:16:43 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id f97-20020a9d03ea000000b00606387601a2sm1226855otf.34.2022.05.05.20.16.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 20:16:42 -0700 (PDT) Date: Thu, 5 May 2022 22:16:37 -0500 From: Bjorn Andersson To: Bhupesh Sharma Cc: linux-arm-msm@vger.kernel.org, bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org, Rob Herring Subject: Re: [PATCH 2/3] arm64: dts: qcom: Fix node names for sdhci 'opp-table' nodes (across dts files) Message-ID: References: <20220429214420.854335-1-bhupesh.sharma@linaro.org> <20220429214420.854335-3-bhupesh.sharma@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220429214420.854335-3-bhupesh.sharma@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 29 Apr 16:44 CDT 2022, Bhupesh Sharma wrote: > Since the Qualcomm sdhci-msm device-tree binding has been converted > to yaml format, 'make dtbs_check' reports a number of issues with > node names for sdhci 'opp-table' nodes, as it doesn't seem to like > any 'preceding text or numbers' before 'opp-table' pattern in the > node names. > > Fix the same. > > Cc: Bjorn Andersson > Cc: Rob Herring > Signed-off-by: Bhupesh Sharma > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 ++-- > arch/arm64/boot/dts/qcom/sm6350.dtsi | 4 ++-- > arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +- > 4 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 86175d257b1e..b6df3186e94c 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -725,7 +725,7 @@ sdhc_1: sdhci@7c4000 { > > status = "disabled"; > > - sdhc1_opp_table: sdhc1-opp-table { > + sdhc1_opp_table: opp-table-sdhc1 { There's only a single opp-table child node of &sdhc_1, so I would prefer that these would just be: sdhc1_opp_table: opp-table { Like what you did in the sm8150 and sm8250 case below. Can you please update this accordingly? Thanks, Bjorn > compatible = "operating-points-v2"; > > opp-100000000 { > @@ -2609,7 +2609,7 @@ sdhc_2: sdhci@8804000 { > > status = "disabled"; > > - sdhc2_opp_table: sdhc2-opp-table { > + sdhc2_opp_table: opp-table-sdhc2 { > compatible = "operating-points-v2"; > > opp-100000000 { > diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi > index fb1a0f662575..87a5d72b2ca0 100644 > --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi > @@ -497,7 +497,7 @@ sdhc_1: sdhci@7c4000 { > > status = "disabled"; > > - sdhc1_opp_table: sdhc1-opp-table { > + sdhc1_opp_table: opp-table-sdhc1 { > compatible = "operating-points-v2"; > > opp-19200000 { > @@ -941,7 +941,7 @@ sdhc_2: sdhci@8804000 { > > status = "disabled"; > > - sdhc2_opp_table: sdhc2-opp-table { > + sdhc2_opp_table: opp-table-sdhc2 { > compatible = "operating-points-v2"; > > opp-100000000 { > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi > index 2700a8145cb9..e265d61f7c05 100644 > --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi > @@ -3563,7 +3563,7 @@ sdhc_2: sdhci@8804000 { > > status = "disabled"; > > - sdhc2_opp_table: sdhc2-opp-table { > + sdhc2_opp_table: opp-table { > compatible = "operating-points-v2"; > > opp-19200000 { > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index dc2562070336..5ca16f76ddeb 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -2937,7 +2937,7 @@ sdhc_2: sdhci@8804000 { > > status = "disabled"; > > - sdhc2_opp_table: sdhc2-opp-table { > + sdhc2_opp_table: opp-table { > compatible = "operating-points-v2"; > > opp-19200000 { > -- > 2.35.1 >