From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1059C433EF for ; Fri, 6 May 2022 20:50:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443784AbiEFUxq (ORCPT ); Fri, 6 May 2022 16:53:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1443555AbiEFUxp (ORCPT ); Fri, 6 May 2022 16:53:45 -0400 Received: from bee.birch.relay.mailchannels.net (bee.birch.relay.mailchannels.net [23.83.209.14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A8546A000; Fri, 6 May 2022 13:50:00 -0700 (PDT) X-Sender-Id: dreamhost|x-authsender|ian@linux.cowan.aero Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 1EF5676116A; Fri, 6 May 2022 20:50:00 +0000 (UTC) Received: from pdx1-sub0-mail-a267.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 866987611B8; Fri, 6 May 2022 20:49:59 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1651870199; a=rsa-sha256; cv=none; b=n6dTuqe0V3FJ3aRB9KvPOEzKNB9dUS+P1xMLRoDk1mgAJCRfDL0mwolk6oOKAAHk1nVzO/ /GywrCz8wmPZ5M71rtUGiX5SWdtqAg2xbeVf8MboCI+6bvGfe0U+vDQJCKfKl4IwD3kqZY gXBM2tSlS2Zx+jglhLtSIUVbSUPhjHkRc4iOBunU+mM3bKXidXGZ0kVchi1LxREGqXSJKv 9ScgVEyk+MiWZhSzl0S1jTCI3+cqya3054oRvHrRVtu8tnbxIaNSOeyQyQxRPEJ2zi7sQk 85NoUR5iO39DPk7wYQZTj4fVRAvS/xGPu27J/uHO3Axw35yAYDpsv0A2Zfep7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1651870199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C+3kDtZyTEFcDrjJVXV0xCqHGqid0l8Y5T5jgapYTQ4=; b=VNQTEsQOLV0/WFoc/YlZNgVKg8G2++ug6oWR+T6Wu5GnPOqubgpj9TBXOt9DCS0AxngXRd tOz1si/aVyfzBGJb0MyK94Vsx/YRNVKPKaLjb9ghhE3ULysberKKe56Z1bSXf1yKdvraHo vF72/STgiGCU21ke7NcR9b7VVwDa+62UY1mKZIcfU6EbFVxAdWVOcC5nWJN1HDkkG/qOwD gjAyqkwij98To29TDzbTpWUaH/L31UUoSKIQGqg/b0VjOSl60EBeI+6FYbKSqfai5QWBUn aJd6G3JcP8CmUxNQ6k5LncYdUAonKI8hclZUsLGr2gj9uZE7YGk45aaDBobCLQ== ARC-Authentication-Results: i=1; rspamd-c4dc5ff8f-qm9bp; auth=pass smtp.auth=dreamhost smtp.mailfrom=ian@linux.cowan.aero X-Sender-Id: dreamhost|x-authsender|ian@linux.cowan.aero X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|ian@linux.cowan.aero X-MailChannels-Auth-Id: dreamhost X-Gusty-Imminent: 088f61e760f53c4d_1651870199940_3946215459 X-MC-Loop-Signature: 1651870199940:1452148033 X-MC-Ingress-Time: 1651870199940 Received: from pdx1-sub0-mail-a267.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.115.45.49 (trex/6.7.1); Fri, 06 May 2022 20:49:59 +0000 Received: from fedora (unknown [69.12.38.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: ian@linux.cowan.aero) by pdx1-sub0-mail-a267.dreamhost.com (Postfix) with ESMTPSA id 4Kw2kY6smCz3V; Fri, 6 May 2022 13:49:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.cowan.aero; s=dreamhost; t=1651870198; bh=C+3kDtZyTEFcDrjJVXV0xCqHGqid0l8Y5T5jgapYTQ4=; h=Date:From:To:Cc:Subject:Content-Type; b=aZ2JeXQk/iWcH5lnZ4lU6SoqriVdbAipjKJ1WCOI0+irhIU76G6/f+mn2UP2Tt1Gl RK4vJPKozshbE8CCvNzwAKEr0SXVky/gSC3Ssezw+ofrvx4J5Zil2Wrh3QHvrgdpbu BXhoyUN97urARPKUoNkN23aI77DTIvwI+gNwNuZ5djpEqCe0AEEfVAQfXM727zcIjc ekYtJbyYbcE4FOAs8hY0Jp9BT25wknzvAEtlsWCHVwaF7j8ZbGoQEYqktNtndmiXWa 98LlAwSSWyFJ1nBnwW627X9Vt4Xdlf9NayVJqRPEXeDQtlqUzWMFv6n7LQinlhiPJ2 opfS8r0C6I6BA== Date: Fri, 6 May 2022 16:49:56 -0400 From: Ian Cowan To: Dan Carpenter Cc: Hans Verkuil , Corentin Labbe , Mauro Carvalho Chehab , Greg Kroah-Hartman , mjpeg-users@lists.sourceforge.net, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] staging: media: zoran: replace dprintk with new debugging macros Message-ID: References: <20220425144110.133316-1-ian@linux.cowan.aero> <3270dd49-0d68-5b60-d766-940b39aa463e@xs4all.nl> <20220506071455.GC4031@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220506071455.GC4031@kadam> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 06, 2022 at 10:14:55AM +0300, Dan Carpenter wrote: > On Fri, May 06, 2022 at 01:30:12AM -0400, Ian Cowan wrote: > > On Thu, Apr 28, 2022 at 10:15:03AM +0200, Hans Verkuil wrote: > > > Hi Ian, > > > > > > When I compiled this patch series with smatch I got these warnings: > > > > > > zoran/videocodec.c:45 videocodec_attach() warn: variable dereferenced before check 'master' (see line 40) > > > zoran/videocodec.c:115 videocodec_detach() warn: variable dereferenced before check 'codec' (see line 111) > > > zoran/videocodec.c:168 videocodec_register() warn: variable dereferenced before check 'codec' (see line 166) > > > zoran/videocodec.c:200 videocodec_unregister() warn: variable dereferenced before check 'codec' (see line 198) > > > > > > And I also got this warning when checking the kerneldoc: > > > > > > zoran/zoran.h:307: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst > > > > > What did you use to see these issues? When I ran the checkpatch script > > and compiled, I did not see any of this. > > > > I have written a blog entry about checking kernel code with Smatch: > > https://staticthinking.wordpress.com/2022/04/25/how-to-run-smatch-on-your-code/ > > regards, > dan carpenter > Fantastic, I'll give that a read. Thanks! Ian