linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	linux-kernel@vger.kernel.org, speakup@linux-speakup.org
Subject: Re: [PATCHv2] speakup: Generate speakupmap.h automatically
Date: Mon, 9 May 2022 16:19:03 +0200	[thread overview]
Message-ID: <Ynki154mxF+2L8WH@kroah.com> (raw)
In-Reply-To: <20220509140705.n3eei4r5ko6bbex4@begin>

On Mon, May 09, 2022 at 04:07:05PM +0200, Samuel Thibault wrote:
> Hello,
> 
> Greg KH, le lun. 09 mai 2022 16:04:43 +0200, a ecrit:
> > Any reason you can't add the code in utils.c into genmap.c and then
> > merge into makemapdata.c to make this a single .c file that does both
> > things?
> 
> Yes: genmap is a tool that end-users can use without needing the Linux
> source code, while makemapdata needs it.

But who will run genmap?

Also you could just put the 90 lines of code into the .h file as inline
functions to get rid of the utils.c to make it a bit simpler.

thanks,

greg k-h

  reply	other threads:[~2022-05-09 14:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-30  0:39 [PATCH] speakup: Generate speakupmap.h automatically Samuel Thibault
2022-04-30  7:33 ` [PATCHv2] " Samuel Thibault
2022-05-09 14:04   ` Greg KH
2022-05-09 14:07     ` Samuel Thibault
2022-05-09 14:19       ` Greg KH [this message]
2022-05-09 14:26         ` Samuel Thibault
2022-05-09 16:28           ` Greg KH
2022-05-09 16:36             ` Samuel Thibault
2022-05-15 23:03   ` [PATCHv3] " Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ynki154mxF+2L8WH@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=speakup@linux-speakup.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).