From: Josh Triplett <josh@joshtriplett.org>
To: Gaelan Steele <gbs@canishe.com>
Cc: Jonathan Corbet <corbet@lwn.net>, Miguel Ojeda <ojeda@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
Jarkko Sakkinen <jarkko@kernel.org>,
Alex Gaynor <alex.gaynor@gmail.com>, Finn Behrens <me@kloenk.de>,
Adam Bratschi-Kaye <ark.email@gmail.com>,
Wedson Almeida Filho <wedsonaf@google.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Sven Van Asbroeck <thesven73@gmail.com>,
Wu XiangCheng <bobwxc@email.cn>, Gary Guo <gary@garyguo.net>,
Boris-Chengbiao Zhou <bobo1239@web.de>,
Yuki Okushi <jtitor@2k36.org>, Wei Liu <wei.liu@kernel.org>,
Daniel Xu <dxu@dxuuu.xyz>, Julian Merkle <me@jvmerkle.de>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v6 18/23] docs: add Rust documentation
Date: Mon, 9 May 2022 22:53:41 -0700 [thread overview]
Message-ID: <Ynn95Sv91TzD4HdT@localhost> (raw)
In-Reply-To: <0716311E-FD5A-489A-A17D-C427C1A0EE4E@canishe.com>
On Mon, May 09, 2022 at 08:14:54PM -0700, Gaelan Steele wrote:
>
>
> > On May 9, 2022, at 3:32 PM, Jonathan Corbet <corbet@lwn.net> wrote:
> >
> >> +It is convenient to instruct editors/IDEs to format while typing,
> >> +when saving or at commit time. However, if for some reason reformatting
> >> +the entire kernel Rust sources is needed at some point, the following can be
> >> +run::
> >> +
> >> + make LLVM=1 rustfmt
> >
> > I will ask whether we want this, though. Why would anybody want to
> > mass-reformat the entire body of kernel code? This seems like something
> > that would generate an endless stream of "helpful" patches and a lot of
> > churn.
>
> That would only happen if the code diverged from rustfmt’s output in the
> first place. Generally, in Rust projects, the source tree is always kept
> formatted with rustfmt - so running `make LLVM=1 rustfmt` would only
> ever touch code that you’d just changed.
Exactly. This is convenient for the same reason doing a project-wide
`cargo fmt` is useful in Rust projects: you can do all your editing,
then format your code before committing.
next prev parent reply other threads:[~2022-05-10 5:54 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-07 5:23 [PATCH v6 00/23] Rust support Miguel Ojeda
2022-05-07 5:23 ` [PATCH v6 01/23] kallsyms: avoid hardcoding the buffer size Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 02/23] kallsyms: support "big" kernel symbols Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 03/23] kallsyms: increase maximum kernel symbol length to 512 Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 04/23] kunit: take `kunit_assert` as `const` Miguel Ojeda
2022-05-12 19:01 ` Brendan Higgins
2022-05-07 5:24 ` [PATCH v6 05/23] rust: add C helpers Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 06/23] rust: add `compiler_builtins` crate Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 07/23] rust: import upstream `alloc` crate Miguel Ojeda
2022-05-07 9:23 ` Kees Cook
2022-05-07 9:33 ` Miguel Ojeda
2022-05-07 17:06 ` Kees Cook
2022-05-07 17:30 ` Linus Torvalds
2022-05-07 19:34 ` Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 08/23] rust: adapt `alloc` crate to the kernel Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 09/23] rust: add `build_error` crate Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 10/23] rust: add `macros` crate Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 11/23] rust: add `kernel` crate's `sync` module Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 12/23] rust: add `kernel` crate Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 13/23] rust: export generated symbols Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 14/23] vsprintf: add new `%pA` format specifier Miguel Ojeda
2022-05-07 8:19 ` Kees Cook
2022-05-07 9:35 ` Miguel Ojeda
2022-05-10 8:38 ` Petr Mladek
2022-05-10 10:45 ` Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 15/23] scripts: add `rustdoc_test_{builder,gen}.py` scripts Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 16/23] scripts: add `generate_rust_analyzer.py` scripts Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 17/23] scripts: decode_stacktrace: demangle Rust symbols Miguel Ojeda
2022-05-07 8:32 ` Kees Cook
2022-05-07 10:21 ` Miguel Ojeda
2022-05-07 17:09 ` Kees Cook
2022-05-07 5:24 ` [PATCH v6 18/23] docs: add Rust documentation Miguel Ojeda
2022-05-07 8:15 ` Kees Cook
2022-05-07 8:45 ` Miguel Ojeda
2022-05-09 4:02 ` Akira Yokosawa
2022-05-09 10:41 ` Miguel Ojeda
2022-05-09 14:56 ` Akira Yokosawa
2022-05-09 22:37 ` Jonathan Corbet
2022-05-10 11:57 ` Miguel Ojeda
2022-05-09 22:32 ` Jonathan Corbet
2022-05-10 3:14 ` Gaelan Steele
2022-05-10 5:53 ` Josh Triplett [this message]
2022-05-11 13:49 ` Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 19/23] Kbuild: add Rust support Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 20/23] samples: add Rust examples Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 21/23] MAINTAINERS: Rust Miguel Ojeda
2022-05-07 8:06 ` Kees Cook
2022-05-07 5:24 ` [PATCH v6 22/23] [RFC] drivers: gpio: PrimeCell PL061 in Rust Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 23/23] [RFC] drivers: android: Binder IPC " Miguel Ojeda
2022-05-07 7:55 ` Kees Cook
2022-05-07 8:13 ` Greg Kroah-Hartman
2022-05-09 17:52 ` Todd Kjos
2022-05-07 8:06 ` [PATCH v6 00/23] Rust support Kees Cook
2022-05-08 18:06 ` Matthew Wilcox
2022-05-09 9:39 ` Wei Liu
2022-05-07 9:29 ` David Gow
2022-05-07 15:03 ` Miguel Ojeda
2022-05-10 4:44 ` David Gow
2022-05-10 11:36 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ynn95Sv91TzD4HdT@localhost \
--to=josh@joshtriplett.org \
--cc=alex.gaynor@gmail.com \
--cc=ark.email@gmail.com \
--cc=bobo1239@web.de \
--cc=bobwxc@email.cn \
--cc=corbet@lwn.net \
--cc=dxu@dxuuu.xyz \
--cc=gary@garyguo.net \
--cc=gbs@canishe.com \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko@kernel.org \
--cc=jtitor@2k36.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=me@jvmerkle.de \
--cc=me@kloenk.de \
--cc=michal.lkml@markovi.net \
--cc=mpe@ellerman.id.au \
--cc=ndesaulniers@google.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=thesven73@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=wedsonaf@google.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).