From: Nathan Chancellor <nathan@kernel.org>
To: Heiko Carstens <hca@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Jonas Paulsson <paulsson@linux.vnet.ibm.com>,
Ulrich Weigand <ulrich.weigand@de.ibm.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Alexander Egorenkov <egorenar@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Andreas Krebbel <krebbel@linux.ibm.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH 0/8] s390: allow to build with llvm's integrated assembler
Date: Wed, 11 May 2022 13:52:13 -0700 [thread overview]
Message-ID: <Ynwh/Uk3IyiyRzO3@dev-arch.thelio-3990X> (raw)
In-Reply-To: <20220511120532.2228616-1-hca@linux.ibm.com>
Hi Heiko,
On Wed, May 11, 2022 at 02:05:24PM +0200, Heiko Carstens wrote:
> A couple of patches which in result make it finally possible to build the
> kernel for s390 with llvm's integrated assembler. Several configs build
> without errors or warnings, and the kernel also works as expected.
>
> Note that patch 6 ("s390/boot: workaround llvm IAS bug") reveals a
> miscompile. This looks like a bug in the instruction definitions of the mvc
> and clc instructions(?). I'd like to ask people to look into this, since
> this silently generated broken code.
I think it should be pretty simple to file a bug report for this since
it occurs in a standalone assembly file? I agree with Nick that there
should be a bug report filed and linked to in patch 6 so that we don't
lose track of it.
> This patch series is based on linux-next, which contains two additional
> required s390 specific patches to make llvm's IAS work.
>
> Thanks,
> Heiko
>
> Heiko Carstens (8):
> s390/alternatives: provide identical sized orginal/alternative sequences
> s390/alternatives: remove padding generation code
> s390/entry: shorten OUTSIDE macro
> s390/entry: workaround llvm's IAS limitations
> s390/purgatory: workaround llvm's IAS limitations
> s390/boot: workaround llvm IAS bug
> s390/boot: do not emit debug info for assembly with llvm's IAS
> scripts/min-tool-version.sh: raise minimum clang version to 14.0.0 for s390
>
> arch/s390/Makefile | 2 +
> arch/s390/boot/head.S | 34 +++++----
> arch/s390/include/asm/alternative-asm.h | 76 +++-----------------
> arch/s390/include/asm/alternative.h | 93 ++++++-------------------
> arch/s390/include/asm/spinlock.h | 2 +-
> arch/s390/kernel/alternative.c | 61 +---------------
> arch/s390/kernel/entry.S | 39 +++++++----
> arch/s390/lib/spinlock.c | 4 +-
> arch/s390/purgatory/head.S | 29 ++++++--
> scripts/min-tool-version.sh | 3 +-
> 10 files changed, 104 insertions(+), 239 deletions(-)
I applied this series to the latest s390 for-next branch (c4fb15578802)
and built a few in-tree and distribution configurations with clang-14
and clang-15 then boot tested them in QEMU with a simple buildroot
userspace. I did not see any new warnings or errors. This is awesome, I
am excited to get this wired up in our CI!
In case it is worthwhile:
Tested-by: Nathan Chancellor <nathan@kernel.org>
Cheers,
Nathan
next prev parent reply other threads:[~2022-05-11 20:52 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 12:05 [PATCH 0/8] s390: allow to build with llvm's integrated assembler Heiko Carstens
2022-05-11 12:05 ` [PATCH 1/8] s390/alternatives: provide identical sized orginal/alternative sequences Heiko Carstens
2022-05-13 9:17 ` Vasily Gorbik
2022-05-11 12:05 ` [PATCH 2/8] s390/alternatives: remove padding generation code Heiko Carstens
2022-05-11 17:02 ` Heiko Carstens
2022-05-13 9:18 ` Vasily Gorbik
2022-05-11 12:05 ` [PATCH 3/8] s390/entry: shorten OUTSIDE macro Heiko Carstens
2022-05-12 15:59 ` kernel test robot
2022-05-12 16:20 ` kernel test robot
2022-05-12 17:21 ` Heiko Carstens
2022-05-12 18:00 ` Nick Desaulniers
2022-05-12 19:15 ` Heiko Carstens
2022-05-12 19:25 ` Nick Desaulniers
2022-05-13 12:29 ` Heiko Carstens
2022-05-11 12:05 ` [PATCH 4/8] s390/entry: workaround llvm's IAS limitations Heiko Carstens
2022-05-11 17:30 ` Nathan Chancellor
2022-05-12 17:24 ` Heiko Carstens
2022-05-12 19:06 ` Nathan Chancellor
2022-05-12 19:16 ` Heiko Carstens
2022-05-16 9:07 ` Alexander Gordeev
2022-05-16 10:19 ` Heiko Carstens
2022-05-16 10:42 ` Jonas Paulsson
2022-05-16 11:11 ` Alexander Gordeev
2022-05-16 14:05 ` Heiko Carstens
2022-05-11 12:05 ` [PATCH 5/8] s390/purgatory: " Heiko Carstens
2022-05-11 19:54 ` Nick Desaulniers
2022-05-12 17:26 ` Heiko Carstens
2022-05-12 17:25 ` Heiko Carstens
2022-05-11 12:05 ` [PATCH 6/8] s390/boot: workaround llvm IAS bug Heiko Carstens
2022-05-11 19:50 ` Nick Desaulniers
2022-05-11 12:05 ` [PATCH 7/8] s390/boot: do not emit debug info for assembly with llvm's IAS Heiko Carstens
2022-05-11 19:40 ` Nick Desaulniers
2022-05-12 17:30 ` Heiko Carstens
2022-05-11 12:05 ` [PATCH 8/8] scripts/min-tool-version.sh: raise minimum clang version to 14.0.0 for s390 Heiko Carstens
2022-05-11 19:27 ` Nick Desaulniers
2022-05-11 19:56 ` Nick Desaulniers
2022-05-12 19:06 ` Heiko Carstens
2022-05-11 19:48 ` [PATCH 0/8] s390: allow to build with llvm's integrated assembler Nick Desaulniers
2022-05-12 19:04 ` Heiko Carstens
2022-05-11 20:52 ` Nathan Chancellor [this message]
2022-05-12 19:03 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ynwh/Uk3IyiyRzO3@dev-arch.thelio-3990X \
--to=nathan@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=egorenar@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=krebbel@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=paulsson@linux.vnet.ibm.com \
--cc=svens@linux.ibm.com \
--cc=ulrich.weigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).