From: Peter Zijlstra <peterz@infradead.org>
To: Borislav Petkov <bp@alien8.de>
Cc: X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 3/3] x86/microcode: Taint and warn on late loading
Date: Wed, 25 May 2022 12:03:52 +0200 [thread overview]
Message-ID: <Yo3/CHaBb/0ULNML@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20220524185324.28395-4-bp@alien8.de>
On Tue, May 24, 2022 at 08:53:24PM +0200, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> Warn when done and taint the kernel.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> ---
> arch/x86/kernel/cpu/microcode/core.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c
> index c717db6b6856..f7ded2facaa0 100644
> --- a/arch/x86/kernel/cpu/microcode/core.c
> +++ b/arch/x86/kernel/cpu/microcode/core.c
> @@ -501,6 +501,8 @@ static int microcode_reload_late(void)
> microcode_check();
>
> pr_info("Reload completed, microcode revision: 0x%x\n", boot_cpu_data.microcode);
> + pr_err("However, late loading is dangerous and it taints the kernel.\n"
> + "You should switch to early loading, if possible.\n");
Should we not warn *before* attempting the ucode update? Should the
whole thing come unstuck, you at least have some clue.
next prev parent reply other threads:[~2022-05-25 10:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 18:53 [RFC PATCH 0/3] x86/microcode: Drop old interface and default-disable late loading Borislav Petkov
2022-05-24 18:53 ` [RFC PATCH 1/3] x86/microcode: Rip out the OLD_INTERFACE Borislav Petkov
2022-05-24 18:53 ` [RFC PATCH 2/3] x86/microcode: Default-disable late loading Borislav Petkov
2022-05-27 10:37 ` Ingo Molnar
2022-05-27 10:58 ` Borislav Petkov
2022-05-24 18:53 ` [RFC PATCH 3/3] x86/microcode: Taint and warn on " Borislav Petkov
2022-05-25 1:03 ` Luck, Tony
2022-05-25 6:59 ` Peter Zijlstra
2022-05-25 7:37 ` Borislav Petkov
2022-05-25 14:50 ` Luck, Tony
2022-05-25 15:28 ` Borislav Petkov
2022-05-25 15:40 ` Luck, Tony
2022-05-25 16:00 ` Borislav Petkov
2022-05-26 12:11 ` Taint addresses Borislav Petkov
2022-05-26 16:41 ` Luck, Tony
2022-05-27 9:45 ` Borislav Petkov
2022-05-25 10:03 ` Peter Zijlstra [this message]
2022-05-25 12:52 ` [RFC PATCH -v2] x86/microcode: Taint and warn on late loading Borislav Petkov
2022-05-25 13:55 ` [PATCH 4/3] x86/microcode: Remove unnecessary perf callback default-disable " Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yo3/CHaBb/0ULNML@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).