linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sean Young <sean@mess.org>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL for v5.18-rc1] media updates
Date: Wed, 25 May 2022 08:40:37 +0100	[thread overview]
Message-ID: <Yo3ddVHgBBlvJEdh@gofer.mess.org> (raw)
In-Reply-To: <a0470450-ecfd-2918-e04a-7b57c1fd7694@kernel.org>

Hi,

On Wed, May 25, 2022 at 08:42:26AM +0200, Jiri Slaby wrote:
> On 22. 03. 22, 10:14, Mauro Carvalho Chehab wrote:
> > Hi Linus,
> > 
> > Please pull from:
> >    git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media tags/media/v5.18-1
> ...
> > Sean Young (10):
> ...
> >        media: lirc: remove unused lirc features
> 
> Hi,
> 
> this breaks lirc build:
> > [   59s] lircd.cpp:489:49: error: 'LIRC_CAN_SET_REC_FILTER' was not declared in this scope; did you mean 'LIRC_CAN_SET_REC_CARRIER'?
> > [   59s]   489 |                     || (curr_driver->features & LIRC_CAN_SET_REC_FILTER)) {
> > [   59s]       |                                                 ^~~~~~~~~~~~~~~~~~~~~~~
> > [   59s]       |                                                 LIRC_CAN_SET_REC_CARRIER
> > [   59s] lircd.cpp: In function 'void loop()':
> > [   59s] lircd.cpp:2069:82: error: 'LIRC_CAN_NOTIFY_DECODE' was not declared in this scope; did you mean 'DRVCTL_NOTIFY_DECODE'?
> > [   59s]  2069 |                         if (curr_driver->drvctl_func && (curr_driver->features & LIRC_CAN_NOTIFY_DECODE))
> > [   59s]       |                                                                                  ^~~~~~~~~~~~~~~~~~~~~~
> > [   59s]       |                                                                                  DRVCTL_NOTIFY_DECODE
> 
> So the uapi header defines should be brought back, IMO.

The lirc.h uapi defines the lirc chardev uapi. The uapi has not changed in
any way, for old or new kernels.

So the lirc header used to have feature flags LIRC_CAN_SET_REC_FILTER and
LIRC_CAN_NOTIFY_DECODE which were defined the in the lirc.h header, but
never implemented by any out of tree or in tree driver.

Neither feature was or will be ever implemented in the kernel;
LIRC_CAN_NOTIFY_DECODE is handled via the led subsytem, and it is unknown
what LIRC_CAN_SET_REC_FILTER is even supposed to mean. Again, I have not
found any implementation anywhere.

You are trying to build lirc user space daemon which is no longer maintained.
The last time the lirc daemon git repo had any commits was in 2019. User
space tooling has been replaced with daemon-less ir-ctl and ir-keytable,
which uses BPF for IR decoding.

The right fix is to simply delete the offending lines in lircd.cpp and all
will be well. Sometimes source code needs a little maintainence. 

These changes in the lirc uapi do not change the uapi in any way, just the
ability the build some unmaintained software without trivial changes.

Thanks,

Sean

  parent reply	other threads:[~2022-05-25  7:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22  9:14 [GIT PULL for v5.18-rc1] media updates Mauro Carvalho Chehab
2022-03-23 23:36 ` pr-tracker-bot
2022-05-25  6:42 ` Jiri Slaby
2022-05-25  6:44   ` lirc build broken [was: [GIT PULL for v5.18-rc1] media updates] Jiri Slaby
2022-05-25  8:57     ` Sean Young
2022-05-25  7:40   ` Sean Young [this message]
2022-05-25  8:09     ` [GIT PULL for v5.18-rc1] media updates Jiri Slaby
2022-05-25  8:49       ` Sean Young
2022-05-25  9:10       ` Sean Young
2022-05-25 10:46         ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yo3ddVHgBBlvJEdh@gofer.mess.org \
    --to=sean@mess.org \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).