From: Catalin Marinas <catalin.marinas@arm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Chengming Zhou <zhouchengming@bytedance.com>,
mark.rutland@arm.com, linux-kernel@vger.kernel.org,
kbuild-all@lists.01.org, lkp@intel.com
Subject: Re: [PATCH] ftrace/fgraph: fix increased missing-prototypes warnings
Date: Wed, 25 May 2022 09:31:36 +0100 [thread overview]
Message-ID: <Yo3paLdqS7oJ/ueL@arm.com> (raw)
In-Reply-To: <20220524191718.5d906700@gandalf.local.home>
On Tue, May 24, 2022 at 07:17:18PM -0400, Steven Rostedt wrote:
> On Fri, 6 May 2022 11:27:37 +0800
> Chengming Zhou <zhouchengming@bytedance.com> wrote:
>
> > After commit e999995c84c3 ("ftrace: cleanup ftrace_graph_caller enable
> > and disable") merged into the linux-next tree, the kernel test robot
> > (lkp@intel.com) has send out report that there are increased missing-prototypes
> > warnings caused by that commit.
> >
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 \
> > O=build_dir ARCH=sh SHELL=/bin/bash kernel/trace/
> > warning: no previous prototype for 'ftrace_enable_ftrace_graph_caller' [-Wmissing-prototypes]
> > warning: no previous prototype for 'ftrace_disable_ftrace_graph_caller' [-Wmissing-prototypes]
> > warning: no previous prototype for 'ftrace_return_to_handler' [-Wmissing-prototypes]
> > warning: no previous prototype for 'ftrace_graph_sleep_time_control' [-Wmissing-prototypes]
> >
> > BTW there are so many missing-prototypes warnings if build kernel with "W=1".
> >
> > The increased warnings for 'ftrace_[enable,disable]_ftrace_graph_caller'
> > is caused by CONFIG_FUNCTION_GRAPH_TRACER && !CONFIG_DYNAMIC_FTRACE,
> > so the declarations in <linux/ftrace.h> can't be seen in fgraph.c.
> >
> > And this warning can't reproduce on x86_64 since x86_64 select
> > HAVE_FUNCTION_GRAPH_TRACER only when DYNAMIC_FTRACE, so fgraph.c will
> > always see the declarations in <linux/ftrace.h>.
> >
> > This patch fix the increased warnings by put the definitions in
> > CONFIG_DYNAMIC_FTRACE although there are no real problems exist.
> >
> > Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
>
> The change this fixes was merged into the ARM tree and I do not have that
> code, so I can not apply this.
Ah, I missed this patch. The commit mentioned is in mainline now but I'm
happy to add it to the arm64 tree and send before -rc1.
--
Catalin
next prev parent reply other threads:[~2022-05-25 8:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 3:27 [PATCH] ftrace/fgraph: fix increased missing-prototypes warnings Chengming Zhou
2022-05-06 3:33 ` Chengming Zhou
2022-05-24 23:17 ` Steven Rostedt
2022-05-25 8:31 ` Catalin Marinas [this message]
2022-05-25 11:30 ` Steven Rostedt
2022-06-01 18:23 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yo3paLdqS7oJ/ueL@arm.com \
--to=catalin.marinas@arm.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mark.rutland@arm.com \
--cc=rostedt@goodmis.org \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).