From: Sean Young <sean@mess.org>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: lirc build broken [was: [GIT PULL for v5.18-rc1] media updates]
Date: Wed, 25 May 2022 09:57:27 +0100 [thread overview]
Message-ID: <Yo3vd4QRmwZsRhlH@gofer.mess.org> (raw)
In-Reply-To: <5c691c83-480b-8731-7e6a-7f28536c9a59@kernel.org>
On Wed, May 25, 2022 at 08:44:38AM +0200, Jiri Slaby wrote:
> On 25. 05. 22, 8:42, Jiri Slaby wrote:
> > On 22. 03. 22, 10:14, Mauro Carvalho Chehab wrote:
> > > Hi Linus,
> > >
> > > Please pull from:
> > > git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media
> > > tags/media/v5.18-1
> > ...
> > > Sean Young (10):
> > ...
> > > media: lirc: remove unused lirc features
> >
> > Hi,
> >
> > this breaks lirc build:
> > > [ 59s] lircd.cpp:489:49: error: 'LIRC_CAN_SET_REC_FILTER' was not
> > > declared in this scope; did you mean 'LIRC_CAN_SET_REC_CARRIER'?
> > > [ 59s] 489 | || (curr_driver->features &
> > > LIRC_CAN_SET_REC_FILTER)) {
> > > [ 59s] |
> > > ^~~~~~~~~~~~~~~~~~~~~~~
> > > [ 59s] |
> > > LIRC_CAN_SET_REC_CARRIER
> > > [ 59s] lircd.cpp: In function 'void loop()':
> > > [ 59s] lircd.cpp:2069:82: error: 'LIRC_CAN_NOTIFY_DECODE' was not
> > > declared in this scope; did you mean 'DRVCTL_NOTIFY_DECODE'?
> > > [ 59s] 2069 | if
> > > (curr_driver->drvctl_func && (curr_driver->features &
> > > LIRC_CAN_NOTIFY_DECODE))
> > > [ 59s] |
> > > ^~~~~~~~~~~~~~~~~~~~~~
> > > [ 59s] |
> > > DRVCTL_NOTIFY_DECODE
> >
> > So the uapi header defines should be brought back, IMO.
>
> (And lirc fixed at the same time.)
What is broken?
Sean
next prev parent reply other threads:[~2022-05-25 8:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 9:14 [GIT PULL for v5.18-rc1] media updates Mauro Carvalho Chehab
2022-03-23 23:36 ` pr-tracker-bot
2022-05-25 6:42 ` Jiri Slaby
2022-05-25 6:44 ` lirc build broken [was: [GIT PULL for v5.18-rc1] media updates] Jiri Slaby
2022-05-25 8:57 ` Sean Young [this message]
2022-05-25 7:40 ` [GIT PULL for v5.18-rc1] media updates Sean Young
2022-05-25 8:09 ` Jiri Slaby
2022-05-25 8:49 ` Sean Young
2022-05-25 9:10 ` Sean Young
2022-05-25 10:46 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yo3vd4QRmwZsRhlH@gofer.mess.org \
--to=sean@mess.org \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).