From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] thermal: rcar_gen3_thermal: improve logging during probe
Date: Wed, 25 May 2022 19:15:51 +0200 [thread overview]
Message-ID: <Yo5kRyBNxiCAWQV4@oden.dyn.berto.se> (raw)
In-Reply-To: <20220525151216.24133-2-wsa+renesas@sang-engineering.com>
Hi Wolfram,
Thanks for your work.
On 2022-05-25 17:12:16 +0200, Wolfram Sang wrote:
> When setting up a new board, a plain "Can't register thermal zone"
> didn't help me much because the thermal zones in DT were all fine. I
> just had a sensor entry too much in the parent TSC node. Reword the
> failure/success messages to contain the sensor number to make it easier
> to understand which sensor is affected. Example output now:
>
> rcar_gen3_thermal e6198000.thermal: Sensor 0: Trip points loaded: 1
> rcar_gen3_thermal e6198000.thermal: Sensor 1: Trip points loaded: 1
> rcar_gen3_thermal e6198000.thermal: Sensor 2: Trip points loaded: 1
> rcar_gen3_thermal e6198000.thermal: Sensor 3: Can't register thermal zone
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
> ---
> drivers/thermal/rcar_gen3_thermal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c
> index ccdf8a24ddc7..ca5558178374 100644
> --- a/drivers/thermal/rcar_gen3_thermal.c
> +++ b/drivers/thermal/rcar_gen3_thermal.c
> @@ -511,7 +511,7 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev)
> zone = devm_thermal_zone_of_sensor_register(dev, i, tsc,
> &rcar_gen3_tz_of_ops);
> if (IS_ERR(zone)) {
> - dev_err(dev, "Can't register thermal zone\n");
> + dev_err(dev, "Sensor %u: Can't register thermal zone\n", i);
> ret = PTR_ERR(zone);
> goto error_unregister;
> }
> @@ -533,7 +533,7 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev)
> if (ret < 0)
> goto error_unregister;
>
> - dev_info(dev, "TSC%u: Loaded %d trip points\n", i, ret);
> + dev_info(dev, "Sensor %u: Trip points loaded: %u\n", i, ret);
> }
>
> if (!priv->num_tscs) {
> --
> 2.35.1
>
--
Kind Regards,
Niklas Söderlund
next prev parent reply other threads:[~2022-05-25 17:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 15:12 [PATCH 1/2] thermal: rcar_gen3_thermal: Add r8a779f0 support Wolfram Sang
2022-05-25 15:12 ` [PATCH 2/2] thermal: rcar_gen3_thermal: improve logging during probe Wolfram Sang
2022-05-25 17:15 ` Niklas Söderlund [this message]
2022-06-09 9:15 ` Geert Uytterhoeven
2022-06-09 13:26 ` Wolfram Sang
2022-05-25 17:11 ` [PATCH 1/2] thermal: rcar_gen3_thermal: Add r8a779f0 support Niklas Söderlund
2022-06-09 9:10 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yo5kRyBNxiCAWQV4@oden.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).