From: Mark Brown <broonie@kernel.org>
To: Eddie James <eajames@linux.ibm.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] spi: fsi: Fix spurious timeout
Date: Wed, 25 May 2022 18:55:18 +0100 [thread overview]
Message-ID: <Yo5thr6nAgNEqJTn@sirena.org.uk> (raw)
In-Reply-To: <20220525165852.33167-2-eajames@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
On Wed, May 25, 2022 at 11:58:51AM -0500, Eddie James wrote:
> I have one concern still, that if the kernel is very busy, it may
> schedule other work for the entire timeout period between assigning
> "end" and checking if timed out in the do/while loop... Is it worth
> worrying about this case?
I'm not sure we can entirely avoid there being a gap, but with it being
a busy loop you'd have to be very unlucky to hit that case. If you come
up with a fix that'd be nice.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-05-25 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 16:58 [PATCH 0/2] spi: fsi: Fix spurious timeout Eddie James
2022-05-25 16:58 ` [PATCH 1/2] " Eddie James
2022-05-25 17:55 ` Mark Brown [this message]
2022-05-25 16:58 ` [PATCH 2/2] spi: core: Display return code when failing to transfer message Eddie James
2022-06-02 8:22 ` Uwe Kleine-König
2022-05-26 18:31 ` [PATCH 0/2] spi: fsi: Fix spurious timeout Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yo5thr6nAgNEqJTn@sirena.org.uk \
--to=broonie@kernel.org \
--cc=eajames@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).