linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Vasily Averin <vvs@openvz.org>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, kernel@openvz.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk-mq: use force attribute for blk_status_t casts
Date: Sun, 15 May 2022 23:53:51 -0700	[thread overview]
Message-ID: <YoH0/2FBC2YS9kk5@infradead.org> (raw)
In-Reply-To: <e3251f58-fd47-9b94-387b-ab641a773dd7@openvz.org>


No, no, no.  Really, stop these patches that just make things worse
now.  __force casts are a really bad idea.  Please just fix this
in a way that does not require casting away these attributes as they
are there for a reason!

  parent reply	other threads:[~2022-05-16  6:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-14 10:03 [PATCH] blk-mq: use force attribute for blk_status_t casts Vasily Averin
2022-05-14 21:24 ` Jens Axboe
2022-05-16  6:53 ` Christoph Hellwig [this message]
2022-05-18 12:45   ` [PATCH v2] blk-mq: fix incorrect " Vasily Averin
2022-05-18 20:35     ` Chaitanya Kulkarni
2022-05-19  7:53     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YoH0/2FBC2YS9kk5@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=kernel@openvz.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vvs@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).