From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CB02C4332F for ; Mon, 16 May 2022 11:44:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232517AbiEPLoa (ORCPT ); Mon, 16 May 2022 07:44:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229697AbiEPLo1 (ORCPT ); Mon, 16 May 2022 07:44:27 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E6BEDFBF; Mon, 16 May 2022 04:44:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F3F77B810DF; Mon, 16 May 2022 11:44:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1FC2AC385AA; Mon, 16 May 2022 11:44:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652701463; bh=EmxLfawp5Dk6/SWKDlV1mvHcmHp8Dr2enYG7AsV29zI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ou5Z19QMaL128kR/T8bZXm/wLzTNxYqOdfkNiXnjEgrc2bo6IWp1OnecrFTlknVgt kQJFP+/VRUDKo+19pG/qpKsrqRrYWxiYanJADfhRwNY55BHgBVmVtKSm5wV+8OaZCr W1zfGmpFtwQa++M5oZ+AIjTP0LCQ00npV+JSoAtEMV63eBIuQaPlFOVHH/q1KNabPD XD8BqzYHXkVGKbCIU3VDjbbECwrqZu8gZCnMmAJsuxWjtrHWR5/EHoIInfwjvMdoA6 IIzcR6b9yvPT9J+lLBrYXSW94MH3L3JfMWSgrurqm9dyJ2Ni6ftLdRWPr/FjPxtClL pxlIMvxpeMRjA== Date: Mon, 16 May 2022 12:44:16 +0100 From: Mark Brown To: Takashi Iwai Cc: Siddh Raman Pant , Jaroslav Kysela , Takashi Iwai , Shuah Khan , alsa-devel@alsa-project.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests: alsa: Better error messages Message-ID: References: <8598037d-0e24-9bc1-3f2c-a2751ec8e871@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5M0Q1jZTiTZHriO1" Content-Disposition: inline In-Reply-To: X-Cookie: May be too intense for some viewers. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5M0Q1jZTiTZHriO1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 16, 2022 at 09:49:04AM +0200, Takashi Iwai wrote: > On Fri, 13 May 2022 15:40:57 +0200, > Siddh Raman Pant wrote: > > This allows for potentially better machine-parsing due to an > > expected / fixed format. Also because of eyecandy reasons. > > Whenever possible, errors will start with the name of the > > offending card/control, separated by the error with colons. > > Whenever there is a description of an error given, the generated > > error string from snd_strerror will be (mostly) enclosed in > > parentheses at the end. > > Clarity of error messages have been (hopefully) improved. > But, honestly speaking, I'm not sure whether it worth. > Although it's possibly a bit more consistent over all texts, I > don't see significant improvement by this change. > But I'm fine to apply it, so keep this pending and would like to > hear from others. Some of it is probably fine but there's a lot of different changes for a lot of different styles in here, not all of which look great to me. --5M0Q1jZTiTZHriO1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKCORAACgkQJNaLcl1U h9DH2wf/V+ceewah5O1Pfdjt0PzOsKcr3er5o2sR3Bn2bVPSb37LtrKyLUXz+PNR F7JqHqiJRA2ynQUsxWpRKneSLj8rMCh1QPl9k4DJiELy5UzhRiEPoKqaF4qyDW0l 03Ts3YCLGoZ8+jUr+ke67Gz63B5kxmrzoXsHjcp8d/xPMy7mUZYtJqzDN2Vdqxqr U6iDhB2qN+sL6dw+2TpYs1PvKjrKETlEaieH0Q4CTJSACs/WN5aYFZNoVzmOgwwC yb+0gevUiAtTZCjgu6Ki+BveQaUa39P3HNoOU9NSdPjkqHt1H7ixIHiaJANzT1xZ VX5E8TqorRsoIoDtvTeoxdbsF7mfWg== =xUpY -----END PGP SIGNATURE----- --5M0Q1jZTiTZHriO1--