From: Tejun Heo <tj@kernel.org>
To: Chengming Zhou <zhouchengming@bytedance.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, duanxiongchun@bytedance.com,
songmuchun@bytedance.com
Subject: Re: [Phishing Risk] [External] Re: [PATCH] blk-iocost: fix very large vtime when iocg activate
Date: Mon, 16 May 2022 15:03:00 -1000 [thread overview]
Message-ID: <YoL0RHmU4tbS2f/F@slm.duckdns.org> (raw)
In-Reply-To: <bcd0956a-9aa0-3211-801b-1f1eace6de79@bytedance.com>
On Tue, May 17, 2022 at 08:57:55AM +0800, Chengming Zhou wrote:
> #define time_after64(a,b) \
> (typecheck(__u64, a) && \
> typecheck(__u64, b) && \
> ((__s64)((b) - (a)) < 0))
> #define time_before64(a,b) time_after64(b,a)
>
> I still don't get why my changes are wrong. :-)
It's a wrapping timestamp where a lower value doesn't necessarily mean
earlier. The before/after relationship is defined only in relation to each
other. Imagine a cirle representing the whole value range and picking two
spots in the circle, if one is in the clockwise half from the other, the
former is said to be earlier than the latter and vice-versa. vtime runs way
faster than nanosecs and wraps regularly, so we can't use absolute values to
compare before/after.
Thanks.
--
tejun
next prev parent reply other threads:[~2022-05-17 1:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 8:40 [PATCH] blk-iocost: fix very large vtime when iocg activate Chengming Zhou
2022-05-16 18:46 ` Tejun Heo
2022-05-17 0:57 ` [Phishing Risk] [External] " Chengming Zhou
2022-05-17 1:03 ` Tejun Heo [this message]
2022-05-17 1:23 ` [Phishing Risk] " Chengming Zhou
2022-05-17 1:39 ` Chengming Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoL0RHmU4tbS2f/F@slm.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=duanxiongchun@bytedance.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=songmuchun@bytedance.com \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).