From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Chen Zhongjin <chenzhongjin@huawei.com>
Cc: alexander.sverdlin@nokia.com, ardb@kernel.org,
linus.walleij@linaro.org, nico@fluxnic.net,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] ARM: module: Add all unwind tables when load module
Date: Tue, 17 May 2022 15:19:00 +0100 [thread overview]
Message-ID: <YoOu1Ng53Tv/ec0d@shell.armlinux.org.uk> (raw)
In-Reply-To: <20220401131534.241205-1-chenzhongjin@huawei.com>
Hi,
On Fri, Apr 01, 2022 at 09:15:34PM +0800, Chen Zhongjin wrote:
> struct mod_arch_specific {
> #ifdef CONFIG_ARM_UNWIND
> - struct unwind_table *unwind[ARM_SEC_MAX];
> + struct unwind_table unwind_list;
Why is this not a:
struct list_head unwind_list;
because, from what I can tell, the _only_ member that is used in this
struct unwind_table is the "mod_list" member - so everything else is
entirely unused and redundant.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-05-17 14:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 13:15 [PATCH v4] ARM: module: Add all unwind tables when load module Chen Zhongjin
2022-04-11 2:26 ` Chen Zhongjin
2022-04-20 3:37 ` Chen Zhongjin
2022-04-28 22:45 ` Linus Walleij
2022-04-29 3:17 ` Chen Zhongjin
2022-05-17 14:19 ` Russell King (Oracle) [this message]
2022-05-20 7:53 ` Chen Zhongjin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoOu1Ng53Tv/ec0d@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexander.sverdlin@nokia.com \
--cc=ardb@kernel.org \
--cc=chenzhongjin@huawei.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).