From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com,
robh+dt@kernel.org, krzk+dt@kernel.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] i2c: designware: introduce a custom scl recovery for SoCFPGA platforms
Date: Thu, 19 May 2022 13:20:51 +0300 [thread overview]
Message-ID: <YoYaA5iTin3rzuob@smile.fi.intel.com> (raw)
In-Reply-To: <20220518202217.85803-1-dinguyen@kernel.org>
On Wed, May 18, 2022 at 03:22:16PM -0500, Dinh Nguyen wrote:
> The I2C pins on the SoCFPGA platforms do not go through a GPIO module,
> thus cannot be recovered by the default method of by doing a GPIO access.
> Only a reset of the I2C IP block can a recovery be successful.
...
> #define MODEL_BAIKAL_BT1 BIT(9)
> #define MODEL_AMD_NAVI_GPU BIT(10)
> +#define MODEL_SOCFPGA BIT(11)
...
> -#define MODEL_MASK GENMASK(11, 8)
> +#define MODEL_MASK GENMASK(12, 8)
Why this change is made?
...
> + switch (dev->flags & MODEL_MASK) {
> + case MODEL_SOCFPGA:
> + rinfo->recover_bus = i2c_custom_scl_recovery;
_custom_ is too broad, use exact name, i.e.
i2c_socfpga_scl_recovery
> + break;
> + default:
> + rinfo->recover_bus = i2c_generic_scl_recovery;
> + break;
> + }
...
> + { .compatible = "intel,socfpga-i2c", .data = (void *)MODEL_SOCFPGA },
> +
Stray change.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-05-19 10:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 20:22 [PATCH 1/2] i2c: designware: introduce a custom scl recovery for SoCFPGA platforms Dinh Nguyen
2022-05-18 20:22 ` [PATCH 2/2] dt-bindings: i2c: dw: Add Intel's SoCFPGA I2C controller Dinh Nguyen
2022-05-21 15:16 ` Krzysztof Kozlowski
2022-05-19 10:20 ` Andy Shevchenko [this message]
2022-05-19 12:41 ` [PATCH 1/2] i2c: designware: introduce a custom scl recovery for SoCFPGA platforms Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoYaA5iTin3rzuob@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).