From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-serial <linux-serial@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Paul Mackerras" <paulus@samba.org>
Subject: Re: [PATCH 1/4] serial: pmac_zilog: remove unfinished DBDMA support
Date: Thu, 19 May 2022 18:23:28 +0200 [thread overview]
Message-ID: <YoZvAJ2y+XS9WP9S@kroah.com> (raw)
In-Reply-To: <b61169e6-259c-f47e-b91f-c6cf3a5e5f39@kernel.org>
On Thu, May 19, 2022 at 11:02:23AM +0200, Jiri Slaby wrote:
> On 19. 05. 22, 10:56, Ilpo Järvinen wrote:
> > On Thu, 19 May 2022, Jiri Slaby wrote:
> >
> > > The support for DBDMA was never completed. Remove the the code that only
> > > maps spaces without real work.
> > >
> > > Cc: Michael Ellerman <mpe@ellerman.id.au>
> > > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > > Cc: Paul Mackerras <paulus@samba.org>
> > > Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> > > ---
> > > drivers/tty/serial/pmac_zilog.c | 38 +--------------------------------
> > > drivers/tty/serial/pmac_zilog.h | 9 --------
> > > 2 files changed, 1 insertion(+), 46 deletions(-)
> > >
> > > diff --git a/drivers/tty/serial/pmac_zilog.c b/drivers/tty/serial/pmac_zilog.c
> > > index c903085acb8d..2953ff64a892 100644
> > > --- a/drivers/tty/serial/pmac_zilog.c
> > > +++ b/drivers/tty/serial/pmac_zilog.c
> >
> > How about dropping this too:
> > #include <asm/dbdma.h>
>
> Good point, fixed, will send v2 eventually.
Add-on patch is fine, thanks!
greg k-h
prev parent reply other threads:[~2022-05-19 16:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 7:56 [PATCH 1/4] serial: pmac_zilog: remove unfinished DBDMA support Jiri Slaby
2022-05-19 7:56 ` [PATCH 2/4] serial: pmac_zilog: remove unused uart_pmac_port::termios_cache Jiri Slaby
2022-05-19 7:56 ` [PATCH 3/4] serial: pmac_zilog: remove tracing prints Jiri Slaby
2022-05-19 7:56 ` [PATCH 4/4] serial: pmac_zilog: remove initial print Jiri Slaby
2022-05-19 8:59 ` Ilpo Järvinen
2022-05-19 8:56 ` [PATCH 1/4] serial: pmac_zilog: remove unfinished DBDMA support Ilpo Järvinen
2022-05-19 9:02 ` Jiri Slaby
2022-05-19 16:23 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoZvAJ2y+XS9WP9S@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benh@kernel.crashing.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).